Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 75045
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.42
Fixed in: (no value)



Subject: do not set $[ in Net::SSLeay
Download (untitled) / with headers
text/plain 391b
hi, per perl5140 delta and perl5120 delta, Assignment to $[ was deprecated and started to give warnings in Perl version 5.12.0. Net::SSLeay uses this in multiple places. Could I suggest one of the 2 approaches to fix this problem? approach 1: only do this conditionally if running less than perl 5.12: local $[ if($] < 5.012); approach2: only localize it if it's set: local $[ if($[);
Subject: Re: [rt.cpan.org #75045] do not set $[ in Net::SSLeay
Date: Thu, 16 Feb 2012 12:04:38 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] open.com.au>
Download (untitled) / with headers
text/plain 1.5k
Hi, Looking in SSLeay.pm, I dont see any assignment to $[ I do see 2 instances of local $[; Its not clear to me why they are there at all? Views? Cheers. On Wednesday, February 15, 2012 07:06:36 PM you wrote: Show quoted text
> Wed Feb 15 19:06:35 2012: Request 75045 was acted upon. > Transaction: Ticket created by TODDR > Queue: Net-SSLeay > Subject: do not set $[ in Net::SSLeay > Broken in: 1.42 > Severity: Normal > Owner: Nobody > Requestors: TODDR@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75045 > > > > hi, per perl5140 delta and perl5120 delta, > > Assignment to $[ was deprecated and started to give warnings in Perl version > 5.12.0. Net::SSLeay uses this in multiple places. > > Could I suggest one of the 2 approaches to fix this problem? > > approach 1: only do this conditionally if running less than perl 5.12: > local $[ if($] < 5.012); > > approach2: only localize it if it's set: > local $[ if($[);
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.
RT-Send-CC: mikem [...] open.com.au
Download (untitled) / with headers
text/plain 349b
On Wed Feb 15 21:04:45 2012, mikem@open.com.au wrote: Show quoted text
> Hi, > > Looking in SSLeay.pm, I dont see any assignment to $[ > I do see 2 instances of > > local $[; > > Its not clear to me why they are there at all? Views?
That’s defensive Perl4-style code. Deleting the ‘local $[’ will have no effect if there are no $[ assignments in scope.
Subject: Re: [rt.cpan.org #75045] do not set $[ in Net::SSLeay
Date: Thu, 16 Feb 2012 12:53:07 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] open.com.au>
Download (untitled) / with headers
text/plain 1.2k
Hello, Thanks for that. It make sense. I have now removed both instances of that from SSLeay.pm in latest svn commit 303. I hope that will satisfy the original poster? Cheers. On Wednesday, February 15, 2012 09:34:34 PM you wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75045 > > > On Wed Feb 15 21:04:45 2012, mikem@open.com.au wrote:
> > Hi, > > > > Looking in SSLeay.pm, I dont see any assignment to $[ > > I do see 2 instances of > > > > local $[; > > > > Its not clear to me why they are there at all? Views?
> > That’s defensive Perl4-style code. Deleting the ‘local $[’ will have no > effect if there are no $[ assignments in scope.
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.
Download (untitled) / with headers
text/plain 461b
On Wed Feb 15 21:53:14 2012, mikem@open.com.au wrote: Show quoted text
> Hello, > > Thanks for that. It make sense. > I have now removed both instances of that from SSLeay.pm in latest svn > commit > 303. > > I hope that will satisfy the original poster?
Yes This was my first preference, but I was unclear if this might have an unexpected effect on any perl script where $[ was altered. If $[ has a limited scope, then I guess that's not a big deal. Thanks for the commit.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.