Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 74788
Status: resolved
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4.300007
Fixed in: (no value)



Subject: ShareDir plugin changes namespaces rudely
Download (untitled) / with headers
text/plain 478b
When the ShareDir plugin recognizes there are sharedirs to be added, it adds these lines to Makefile.PL: package MY; use File::ShareDir::Install qw(postamble); Unfortunately, other plugins add content below this point, which is now in a different namespace. This breaks the Conflicts plugin, as check_conflicts() is called at the top of the file but the sub definition is below the namespace change. Thanks doy for discovering this. Fix coming up in my github.
Download (untitled) / with headers
text/plain 207b
Show quoted text
> Fix coming up in my github.
Fix in master at https://github.com/karenetheridge/Test-Deep -- I won't send a pull request as there is already a pull request open for the GenerateFile::FileMunged plugin.
Download (untitled) / with headers
text/plain 761b
This has been fixed: commit 08eff25fa9680bdfded2d3273a472a002a231085 Author: Karen Etheridge <ether@cpan.org> Date: Wed Feb 8 20:40:06 2012 +0000 enclose code in MY namespace in braces to avoid breaking code inserted later diff --git a/lib/Dist/Zilla/Plugin/MakeMaker.pm b/lib/Dist/Zilla/Plugin/MakeMaker.pm index af9d5ba..9e2f48d 100644 --- a/lib/Dist/Zilla/Plugin/MakeMaker.pm +++ b/lib/Dist/Zilla/Plugin/MakeMaker.pm @@ -167,7 +167,7 @@ sub setup_installer { @share_dir_block = ( $preamble, - qq{package\nMY;\nuse File::ShareDir::Install qw(postamble);\n}, + qq{\{\npackage\nMY;\nuse File::ShareDir::Install qw(postamble);\n\}\n}, ); }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.