Skip Menu |
 

This queue is for tickets about the CGI-Simple CPAN distribution.

Report information
The Basics
Id: 74732
Status: open
Priority: 0/
Queue: CGI-Simple

People
Owner: Nobody in particular
Requestors: dom [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.113
Fixed in: (no value)



Subject: Uses deprecated shellwords.pl
Download (untitled) / with headers
text/plain 112b
Hi, I've applied the attached patch to CGI::Simple in Debian; you might like to do the same. Cheers, Dominic.
Subject: no-shellwords-pl.patch
From: Dominic Hargreaves <dom@earth.li> Subject: Use Text::ParseWords instead of shellwords.pl The shellwords.pl library is deprecated and will be removed in a future version of perl. Text::ParseWords has been in core since 5.0.0 and it is used by shellwords.pl already. Adapted from <https://github.com/markstos/CGI.pm/commit/0cf175dbfbeaa46d71343412c715096da5bd0eaf> diff --git a/lib/CGI/Simple.pm b/lib/CGI/Simple.pm index 230606f..85b02fb 100644 --- a/lib/CGI/Simple.pm +++ b/lib/CGI/Simple.pm @@ -1185,10 +1185,10 @@ sub read_from_cmdline { @words = @ARGV; } elsif ( $_[0]->{'.globals'}->{'DEBUG'} == 2 ) { - require "shellwords.pl"; + require Text::ParseWords; print "(offline mode: enter name=value pairs on standard input)\n"; chomp( my @lines = <STDIN> ); - @words = &shellwords( join " ", @lines ); + @words = &Text::ParseWords::old_shellwords( join " ", @lines ); } else { return '';
Sorry, this is a duplicate of <https://rt.cpan.org/Ticket/Display.html? id=71065>.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.