Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla-Plugin-MetaProvides-Package CPAN distribution.

Report information
The Basics
Id: 74675
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-MetaProvides-Package

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.14000000



Subject: Should ignore "private" packages
Download (untitled) / with headers
text/plain 398b
This scanner picks up "private" packages that are hidden with the "package\n Foo::Bar;" convention of putting package on a separate line. It also picks up packages that have a leading underscore like "Foo::Bar::_internal::Whatever". Both of those should not be reported in provides. Ideally that would be the default behavior, but an option to do so would be acceptable as well. Thanks! David

Thanks for the bug report, I didn't even notice it was reporting private namespaces.

 

Filtering out the  X::_Y form should be easy enough, just   package\nX; form might prove more difficult as its handled by Module::Extract::Namespaces at present, which in turn does it via PPI  ( also, damn you metacpan for being down, yay for search.cpan.org still working ), which is on my list of giant hairy bastards so hairy I employ yaks to shave it.

 

 

Subject: Re: [rt.cpan.org #74675] Should ignore "private" packages
Date: Sat, 4 Feb 2012 07:02:37 -0500
To: bug-Dist-Zilla-Plugin-MetaProvides-Package [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 675b
On Sat, Feb 4, 2012 at 12:19 AM, Kent Fredric via RT <bug-Dist-Zilla-Plugin-MetaProvides-Package@rt.cpan.org> wrote: Show quoted text
> Filtering out the X::_Y form should be easy enough, just package\nX; form might > prove more difficult as its handled by Module::Extract::Namespaces at present, > which in turn does it via PPI ( also, damn you metacpan for being down, yay for > search.cpan.org still working ), which is on my list of giant hairy bastards so > hairy I employ yaks to shave it.
I suggest you consider using Module::Metadata instead, which is what Module::Build and ExtUtils::MakeMaker use for generating "provides" for META. That would ensure consistency. Regards, David
Release is out, hopefully its to your liking =)

https://metacpan.org/source/KENTNL/Dist-Zilla-Plugin-MetaProvides-Package-1.14000000/Changes#L4

Somewhat-formal valedictions,

Kent

Subject: Re: [rt.cpan.org #74675] Should ignore "private" packages
Date: Tue, 7 Feb 2012 22:34:37 -0500
To: bug-Dist-Zilla-Plugin-MetaProvides-Package [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 580b
On Tue, Feb 7, 2012 at 9:53 AM, Kent Fredric via RT <bug-Dist-Zilla-Plugin-MetaProvides-Package@rt.cpan.org> wrote: Show quoted text
Thanks! FWIW, the new Module::Metadata 1.000008 now has a "provides" method that should give you pretty much exactly what you need. I discovered the packages_inside gives you the raw output, without filtering. I've also documented it better. David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.