Skip Menu |
 

This queue is for tickets about the Jifty-DBI CPAN distribution.

Report information
The Basics
Id: 74298
Status: resolved
Priority: 0/
Queue: Jifty-DBI

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.72
Fixed in: 0.73



Subject: Bleadperl v5.15.6-118-g2846acb breaks TSIBLEY/Jifty-DBI-0.72.tar.gz
Download (untitled) / with headers
text/plain 110b
Related ticket: https://rt.cpan.org/Ticket/Display.html?id=73806 I hope this helps a bit, Thanks && Regards,
Download (untitled) / with headers
text/plain 908b
On Mon Jan 23 18:43:16 2012, ANDK wrote: Show quoted text
> Related ticket: > > https://rt.cpan.org/Ticket/Display.html?id=73806 > > I hope this helps a bit, > Thanks && Regards,
Are you sure 2846acb was responsible? I get this error, which suggests da1dff9483 instead: Can't modify non-lvalue subroutine call at /Users/sprout/.cpan/build/Jifty-DBI-0.72- ClEIBc/blib/lib/Jifty/DBI/Column.pm line 94. BEGIN failed--compilation aborted at t/01records.t line 317. Line 94 of Column.pm is: $self->can($_) ? $self->$_($args->{$_}) : $self->attributes->{$_} = $args->{$_}; which is clearly a mistake, as it assigns $args->{$_} to $self->$_($args->{$_}) if $self- Show quoted text
>can($_).
It should be: $self->can($_) ? $self->$_($args->{$_}) : ($self->attributes->{$_} = $args->{$_}); or, more clearly: $self->can($_) ? $self->$_($args->{$_}) : ($self->attributes->{$_} = $args->{$_});
Download (untitled) / with headers
text/plain 1.1k
On Tue Jan 24 01:22:55 2012, SPROUT wrote: Show quoted text
> On Mon Jan 23 18:43:16 2012, ANDK wrote:
> > Related ticket: > > > > https://rt.cpan.org/Ticket/Display.html?id=73806 > > > > I hope this helps a bit, > > Thanks && Regards,
> > Are you sure 2846acb was responsible? I get this error, which > suggests da1dff9483 instead: > > Can't modify non-lvalue subroutine call at > /Users/sprout/.cpan/build/Jifty-DBI-0.72- > ClEIBc/blib/lib/Jifty/DBI/Column.pm line 94. > BEGIN failed--compilation aborted at t/01records.t line 317. > > Line 94 of Column.pm is: > > $self->can($_) ? $self->$_($args->{$_}) : $self->attributes-
> >{$_} = $args->{$_};
> > which is clearly a mistake, as it assigns $args->{$_} to $self-
> >$_($args->{$_}) if $self- > >can($_).
> > It should be: > > $self->can($_) ? $self->$_($args->{$_}) : ($self->attributes-
> >{$_} = $args->{$_});
> > or, more clearly: > > $self->can($_) > ? $self->$_($args->{$_}) > : ($self->attributes->{$_} = $args->{$_});
I forgot to add: Perl is not JavaScript. :-) In JavaScript, = and ? : have the same precedence and are right-associative, but in Perl ? : is higher.
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #74298] Bleadperl v5.15.6-118-g2846acb breaks TSIBLEY/Jifty-DBI-0.72.tar.gz
Date: Tue, 24 Jan 2012 08:19:26 +0100
To: bug-Jifty-DBI [...] rt.cpan.org
From: andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)
Download (untitled) / with headers
text/plain 350b
Show quoted text
>>>>> On Tue, 24 Jan 2012 01:26:18 -0500, "Father Chrysostomos via RT" <bug-Jifty-DBI@rt.cpan.org> said:
Show quoted text
>> Are you sure 2846acb was responsible? I get this error, which >> suggests da1dff9483 instead: >> >> [...]
You're right, in the meantime I got a pass for v5.15.6-118-g2846acb. No idea what caused my previous fail. Thanks! -- andreas
Download (untitled) / with headers
text/plain 425b
On Tue Jan 24 02:19:41 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote: Show quoted text
> >>>>> On Tue, 24 Jan 2012 01:26:18 -0500, "Father Chrysostomos via RT"
> <bug-Jifty-DBI@rt.cpan.org> said: >
> >> Are you sure 2846acb was responsible? I get this error, which > >> suggests da1dff9483 instead: > >> > >> [...]
> > You're right, in the meantime I got a pass for v5.15.6-118-g2846acb.
This appears to be related to #73972.
Subject: Re: [rt.cpan.org #74298] Bleadperl v5.15.6-118-g2846acb breaks TSIBLEY/Jifty-DBI-0.72.tar.gz
Date: Wed, 25 Jan 2012 16:00:28 -0500
To: bug-Jifty-DBI [...] rt.cpan.org
From: Thomas Sibley <trs [...] bestpractical.com>
Download (untitled) / with headers
text/plain 781b
On 01/24/2012 01:26 AM, Father Chrysostomos via RT wrote: Show quoted text
>> Can't modify non-lvalue subroutine call at >> /Users/sprout/.cpan/build/Jifty-DBI-0.72- >> ClEIBc/blib/lib/Jifty/DBI/Column.pm line 94. >> BEGIN failed--compilation aborted at t/01records.t line 317. >> >> Line 94 of Column.pm is: >> >> $self->can($_) ? $self->$_($args->{$_}) : $self->attributes-
>>> {$_} = $args->{$_};
>> >> which is clearly a mistake, as it assigns $args->{$_} to $self-
>>> $_($args->{$_}) if $self- >>> can($_).
Thanks for the heads up. That line is indeed a mistake. I committed e126c9124 to fix it: https://github.com/bestpractical/jifty-dbi/commit/e126c9124 Can you confirm the fix with blead? If so, I'll release 0.73. Show quoted text
> I forgot to add: Perl is not JavaScript. :-)
:) Thomas
On Wed Jan 25 16:00:29 2012, trs@bestpractical.com wrote: Show quoted text
> On 01/24/2012 01:26 AM, Father Chrysostomos via RT wrote:
> >> Can't modify non-lvalue subroutine call at > >> /Users/sprout/.cpan/build/Jifty-DBI-0.72- > >> ClEIBc/blib/lib/Jifty/DBI/Column.pm line 94. > >> BEGIN failed--compilation aborted at t/01records.t line 317. > >> > >> Line 94 of Column.pm is: > >> > >> $self->can($_) ? $self->$_($args->{$_}) : $self->attributes-
> >>> {$_} = $args->{$_};
> >> > >> which is clearly a mistake, as it assigns $args->{$_} to $self-
> >>> $_($args->{$_}) if $self- > >>> can($_).
> > Thanks for the heads up. That line is indeed a mistake. I committed > e126c9124 to fix it: > > https://github.com/bestpractical/jifty-dbi/commit/e126c9124
The commit message mentions the wrong commit (as does the subject of this ticket). It was actually v5.15.6-179-gda1dff9. Show quoted text
> Can you confirm the fix with blead? If so, I'll release 0.73.
It works. (I tested it with v5.15.7-48-g9a8aa25.) Show quoted text
>
> > I forgot to add: Perl is not JavaScript. :-)
> > :) > > Thomas
Subject: Re: [rt.cpan.org #74298] Bleadperl v5.15.6-118-g2846acb breaks TSIBLEY/Jifty-DBI-0.72.tar.gz
Date: Wed, 25 Jan 2012 16:47:42 -0500
To: bug-Jifty-DBI [...] rt.cpan.org
From: Thomas Sibley <trs [...] bestpractical.com>
Download (untitled) / with headers
text/plain 407b
On 01/25/2012 04:22 PM, Father Chrysostomos via RT wrote: Show quoted text
> The commit message mentions the wrong commit (as does the subject of this ticket). It was > actually v5.15.6-179-gda1dff9.
Ah, bugger. Show quoted text
>> Can you confirm the fix with blead? If so, I'll release 0.73.
> > It works. (I tested it with v5.15.7-48-g9a8aa25.)
Thanks! I just pushed a new release to CPAN. Marking this bug as resolved. Thomas
Download (untitled) / with headers
text/plain 708b
On Wed Jan 25 16:47:44 2012, trs@bestpractical.com wrote: Show quoted text
> On 01/25/2012 04:22 PM, Father Chrysostomos via RT wrote:
> > The commit message mentions the wrong commit (as does the subject of
> this ticket). It was
> > actually v5.15.6-179-gda1dff9.
> > Ah, bugger. >
> >> Can you confirm the fix with blead? If so, I'll release 0.73.
> > > > It works. (I tested it with v5.15.7-48-g9a8aa25.)
> > Thanks! I just pushed a new release to CPAN. Marking this bug as > resolved.
Sorry to re-open it, but I’ve just noticed that the Changes file calls it a compilation error. It is actually a run-time error, as perl doesn’t know at compilation time that you are not using an lvalue sub as a method.
Subject: Re: [rt.cpan.org #74298] Bleadperl v5.15.6-118-g2846acb breaks TSIBLEY/Jifty-DBI-0.72.tar.gz
Date: Thu, 26 Jan 2012 09:34:54 -0500
To: bug-Jifty-DBI [...] rt.cpan.org
From: Thomas Sibley <trs [...] bestpractical.com>
Download (untitled) / with headers
text/plain 750b
On 01/25/2012 07:52 PM, Father Chrysostomos via RT wrote: Show quoted text
> Sorry to re-open it, but I’ve just noticed that the Changes file calls it a compilation error. It is > actually a run-time error, as perl doesn’t know at compilation time that you are not using an > lvalue sub as a method.
Oops, that's obvious in retrospect. I keyed on "compilation aborted" in the reported error when I was throwing together the fix. This is what I get -- along with the forgotten Changes update in 0.73 requiring 0.74 and the wrong blead version from the Subject -- for trying to release quickly without my own failing test case while juggling many other things. I fixed the Changes file, but I'm not going to bother with a new release. Thanks again. Thomas


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.