Skip Menu |
 

This queue is for tickets about the Data-Dump-Streamer CPAN distribution.

Report information
The Basics
Id: 74198
Status: resolved
Priority: 0/
Queue: Data-Dump-Streamer

People
Owner: Nobody in particular
Requestors: voegelas [...] cpan.org
Cc: chris [...] bingosnet.co.uk
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.32
Fixed in: (no value)



CC: chris [...] bingosnet.co.uk
Subject: t/madness.t fails under Perl 5.15.7 ("use strict 'refs'" vs. "use strict")
Download (untitled) / with headers
text/plain 435b
Under Perl 5.15.7, the Data::Dump::Streamer modules's test suite fails in t/madness.t. Test #7 expects "use strict 'refs'" but gets "use strict". See the attached output of "./Build test verbose=1". The affected code fragment in t/madness.t looks like this: if ( $] >= 5.012_000 ) { [...] CR => sub { use warnings; use strict 'refs'; 'code'; },
Subject: Data_Dump_Streamer_Build_test_verbose.txt
t/madness.t ......... 1..7 ok 1 - use Data::Dump::Streamer; ok 2 - The object isa Data::Dump::Streamer ok 3 - Madness cap( $qr,$qr ) ok 4 - Total Madness ok 5 - More Madness ok 6 - Tye Alias Array not ok 7 - Expected: $HASH1 = { AR => [ 1, 2 ], CR => sub { use warnings; use strict 'refs'; 'code'; }, FMT => \do{ local *F; my $F=<<'_EOF_FORMAT_'; $F=~s/^\s+# //mg; eval $F; die $F.$@ if $@; *F{FORMAT}; # format F = # @<<<<<< @││││││ @>>>>>> # 'left', 'middle', 'right' # . _EOF_FORMAT_ }, GLB => *::STDERR, HR => { key => 'value' }, IO => bless( *{Symbol::gensym()}{IO}, 'IO::File' ), IV => 1, NV => 3.14159265358979, OBJ => bless( qr/("[^"]+")/, 'Zorp' ), PV => 'string', PV8 => "ab\ncd\x{20ac}\t", PVM => '', RV => \do { my $v = undef }, UND => undef }; Got: $HASH1 = { AR => [ 1, 2 ], CR => sub { use warnings; use strict; 'code'; }, FMT => \do{ local *F; my $F=<<'_EOF_FORMAT_'; $F=~s/^\s+# //mg; eval $F; die $F.$@ if $@; *F{FORMAT}; # format F = # @<<<<<< @││││││ @>>>>>> # 'left', 'middle', 'right' # . _EOF_FORMAT_ }, GLB => *::STDERR, HR => { key => 'value' }, IO => bless( *{Symbol::gensym()}{IO}, 'IO::File' ), IV => 1, NV => 3.14159265358979, OBJ => bless( qr/("[^"]+")/, 'Zorp' ), PV => 'string', PV8 => "ab\ncd\x{20ac}\t", PVM => '', RV => \do { my $v = undef }, UND => undef }; +---+ S 1 : 0x95ac498(c 2| 1) Dp: 1 RW Du:1 => $HASH1 S 2 : 0x95bee20(c 3| 1) Dp: 5 RW Du:1 => ${$HASH1->{FMT}} < $HASH1->{FMT} > S 3 : 0x90fb8b8(c 4| 1) Dp: 5 RW Du:1 => ${$HASH1->{RV}} < $HASH1->{RV} > ----- R 1 : 0x9563e08(c 2|-1) Dp: 2 Du:1 => $HASH1 R 2 : 0x95aa5b0(c 1|-1) Dp: 4 Du:1 => $HASH1->{AR} R 3 : 0x94ecad8(c 1|-1) Dp: 4 Du:1 => $HASH1->{CR} R 4 : 0x95bee20(c 1|-1) Dp: 4 Du:1 => $HASH1->{FMT} < ${$HASH1->{FMT}} > R 5 : 0x95a4900(c 1|-1) Dp: 4 Du:1 => $HASH1->{HR} R 6 : 0x8fbf960(c 1|-1) Dp: 4 Du:1 => $HASH1->{IO} R 7 : 0x95b4688(c 1|-1) Dp: 4 Du:1 => $HASH1->{OBJ} R 8 : 0x90fb8b8(c 1|-1) Dp: 4 Du:1 => $HASH1->{RV} < ${$HASH1->{RV}} > R 9 : 0x9563d78(c 3|-1) Dp: 6 Du:1 => ${$HASH1->{FMT}} +---+ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests
Download (untitled) / with headers
text/plain 387b
On Sat Jan 21 05:19:19 2012, voegelas wrote: Show quoted text
> Under Perl 5.15.7, the Data::Dump::Streamer modules's test suite fails > in t/madness.t. Test #7 expects "use strict 'refs'" but gets "use > strict". See the attached output of "./Build test verbose=1". The > affected code fragment in t/madness.t looks like this:
Attached is a patch to madness.t, but globtest.t is also failing for me....
Subject: open_lg4aQ35t.txt
Download open_lg4aQ35t.txt
text/plain 1.1k
diff -rup Data-Dump-Streamer-2.32-TNHJsO/t/madness.t Data-Dump-Streamer-2.32-TNHJsO-copy/t/madness.t --- Data-Dump-Streamer-2.32-TNHJsO/t/madness.t 2012-01-22 16:27:36.000000000 -0800 +++ Data-Dump-Streamer-2.32-TNHJsO-copy/t/madness.t 2012-01-22 16:27:09.000000000 -0800 @@ -249,7 +249,7 @@ format STDOUT = # IO handles are now blessed into IO::File, I guess? # if ( $] >= 5.012_000 ) { - same( $dump= $o->Data(\%hash)->Out, template( <<'EXPECT', expected_dot => $expected_dot ), "", $o); + my $expect = <<'EXPECT'; $HASH1 = { AR => [ 1, @@ -280,6 +280,13 @@ _EOF_FORMAT_ UND => undef }; EXPECT + require B::Deparse; + if (new B::Deparse -> coderef2text ( + sub { no strict; 1; use strict; 1; } + ) !~ 'refs') { + $expect =~ s/strict 'refs'/strict/; + } + same( $dump= $o->Data(\%hash)->Out, template( $expect, expected_dot => $expected_dot ), "", $o); } elsif ( $] >= 5.008_008 ) { same( $dump= $o->Data(\%hash)->Out, template( <<'EXPECT', expected_dot => $expected_dot ), "", $o);
On Sun Jan 22 19:29:03 2012, SPROUT wrote: Show quoted text
> globtest.t is also failing for me....
Here is the output: $ perl5.15.7 -Mblib t/globtest.t 1..19 ok 1 - use Data::Dump::Streamer; ok 2 - The object isa Data::Dump::Streamer ok 3 - a glob ok 4 - scalar slot ok 5 - data slots (glob/FORMAT) ok 6 - data slots (ref/FORMAT) ok 7 - data slots (blessed FORMAT) ok 8 - data slots (empty FORMAT) ok 9 - self glob not ok 10 - icky SCALAR slot # Failed test 'icky SCALAR slot' # at t/test_helper.pl line 114. Expected: $RO1 = 'cannae be modified'; make_ro($RO1); $VAR1 = 'do as you please'; Got: $VAR1 = 'cannae be modified'; make_ro($VAR1); $VAR2 = 'do as you please'; +---+ S 1 : 0x882cf0(c 3| 1) Dp: 1 RO Du:1 => $VAR1 S 2 : 0x883360(c 2| 1) Dp: 1 RW Du:1 => $VAR2 +---+ ok 11 - Named Globs ok 12 - Named Globs Two ok 13 - Named Globs Declare ok 14 - Named Globs Two Declare ok 15 - Symbol 1 ok 16 - Symbol 2 ok 17 - Symbol 3 ok 18 - Symbol 4 ok 19 - Symbol 5 # Looks like you failed 1 test of 19. Andreas, was this caused by the same commit, or another?
RT-Send-CC: ANDK [...] cpan.org
Download (untitled) / with headers
text/plain 1.3k
On Sun Jan 22 19:32:32 2012, SPROUT wrote: Show quoted text
> On Sun Jan 22 19:29:03 2012, SPROUT wrote:
> > globtest.t is also failing for me....
> > Here is the output: > > $ perl5.15.7 -Mblib t/globtest.t > 1..19 > ok 1 - use Data::Dump::Streamer; > ok 2 - The object isa Data::Dump::Streamer > ok 3 - a glob > ok 4 - scalar slot > ok 5 - data slots (glob/FORMAT) > ok 6 - data slots (ref/FORMAT) > ok 7 - data slots (blessed FORMAT) > ok 8 - data slots (empty FORMAT) > ok 9 - self glob > not ok 10 - icky SCALAR slot > # Failed test 'icky SCALAR slot' > # at t/test_helper.pl line 114. > Expected: > $RO1 = 'cannae be modified'; > make_ro($RO1); > $VAR1 = 'do as you please'; > Got: > $VAR1 = 'cannae be modified'; > make_ro($VAR1); > $VAR2 = 'do as you please'; > +---+ > S 1 : 0x882cf0(c 3| 1) Dp: 1 RO Du:1 => $VAR1 > S 2 : 0x883360(c 2| 1) Dp: 1 RW Du:1 => $VAR2 > +---+ > ok 11 - Named Globs > ok 12 - Named Globs Two > ok 13 - Named Globs Declare > ok 14 - Named Globs Two Declare > ok 15 - Symbol 1 > ok 16 - Symbol 2 > ok 17 - Symbol 3 > ok 18 - Symbol 4 > ok 19 - Symbol 5 > # Looks like you failed 1 test of 19. > > Andreas, was this caused by the same commit, or another?
Sorry, I mistakenly thought this ticket was filed by Andreas König. Andreas König (now cc’ed): Can you find out which commit causes globtest.t to fail?
CC: sprout [...] cpan.org
Subject: Re: [rt.cpan.org #74198] t/madness.t fails under Perl 5.15.7 ("use strict 'refs'" vs. "use strict")
Date: Mon, 23 Jan 2012 08:47:58 +0100
To: bug-Data-Dump-Streamer [...] rt.cpan.org
From: andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)
Download (untitled) / with headers
text/plain 264b
Show quoted text
>>>>> On Sun, 22 Jan 2012 19:35:37 -0500, "Father Chrysostomos via RT" <bug-Data-Dump-Streamer@rt.cpan.org> said:
Show quoted text
> Andreas König (now cc’ed): Can you find out which commit causes globtest.t to fail?
I'm sorry, globtest.t does not fail for me. -- andreas
Subject: Re: [rt.cpan.org #74198] t/madness.t fails under Perl 5.15.7 ("use strict 'refs'" vs. "use strict")
Date: Mon, 23 Jan 2012 15:14:29 +0100
To: bug-Data-Dump-Streamer [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
Download (untitled) / with headers
text/plain 1.4k
On 23 January 2012 01:32, Father Chrysostomos via RT <bug-Data-Dump-Streamer@rt.cpan.org> wrote: Show quoted text
>       Queue: Data-Dump-Streamer >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=74198 > > > On Sun Jan 22 19:29:03 2012, SPROUT wrote:
>> globtest.t is also failing for me....
> > Here is the output: > > $ perl5.15.7 -Mblib t/globtest.t > 1..19 > ok 1 - use Data::Dump::Streamer; > ok 2 - The object isa Data::Dump::Streamer > ok 3 - a glob > ok 4 - scalar slot > ok 5 - data slots (glob/FORMAT) > ok 6 - data slots (ref/FORMAT) > ok 7 - data slots (blessed FORMAT) > ok 8 - data slots (empty FORMAT) > ok 9 - self glob > not ok 10 - icky SCALAR slot > #   Failed test 'icky SCALAR slot' > #   at t/test_helper.pl line 114. > Expected: > $RO1 = 'cannae be modified'; > make_ro($RO1); > $VAR1 = 'do as you please'; > Got: > $VAR1 = 'cannae be modified'; > make_ro($VAR1); > $VAR2 = 'do as you please'; > +---+ > S  1 : 0x882cf0(c 3| 1) Dp: 1 RO  Du:1 => $VAR1 > S  2 : 0x883360(c 2| 1) Dp: 1 RW Du:1 => $VAR2 > +---+ > ok 11 - Named Globs > ok 12 - Named Globs Two > ok 13 - Named Globs Declare > ok 14 - Named Globs Two Declare > ok 15 - Symbol 1 > ok 16 - Symbol 2 > ok 17 - Symbol 3 > ok 18 - Symbol 4 > ok 19 - Symbol 5 > # Looks like you failed 1 test of 19. > > Andreas, was this caused by the same commit, or another?
Would you like a commit bit FC? Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
Download (untitled) / with headers
text/plain 246b
On Mon Jan 23 09:14:42 2012, demerphq@gmail.com wrote: Show quoted text
> Would you like a commit bit FC?
I’m afraid a commit bit might take me away from perl developement, and I haven’t finished fixing all of perl’s bugs yet. So, not now, at least. :-)
RT-Send-CC: ANDK [...] cpan.org
Download (untitled) / with headers
text/plain 473b
On Mon Jan 23 02:48:08 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote: Show quoted text
> >>>>> On Sun, 22 Jan 2012 19:35:37 -0500, "Father Chrysostomos via RT"
> <bug-Data-Dump-Streamer@rt.cpan.org> said: >
> > Andreas König (now cc’ed): Can you find out which commit causes
> globtest.t to fail? > > I'm sorry, globtest.t does not fail for me.
And it doesn’t fail for me any more, either, after reinstalling perl 5.15.7 without -Dmad. So I suspect that was the problem.
RT-Send-CC: ANDK [...] cpan.org, andreas.koenig.7os6VVqR [...] franz.ak.mind.de, demerphq [...] gmail.com, sprout [...] cpan.org, chris [...] bingosnet.co.uk
The attached patch (by sprout?) fixes my problems against blead. I'm guessing it's still needed.
Subject: Re: [rt.cpan.org #74198] t/madness.t fails under Perl 5.15.7 ("use strict 'refs'" vs. "use strict")
Date: Sat, 11 Feb 2012 00:26:21 +0100
To: bug-Data-Dump-Streamer [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
Download (untitled) / with headers
text/plain 451b
On 10 February 2012 21:21, Todd Rinaldo via RT <bug-Data-Dump-Streamer@rt.cpan.org> wrote: Show quoted text
>       Queue: Data-Dump-Streamer >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=74198 > > > The attached patch (by sprout?)  fixes my problems against blead. I'm guessing it's still needed.
Sorry for personal reasons I have not been able to look into this, I will try to next week. Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
RT-Send-CC: sprout [...] cpan.org, chris [...] bingosnet.co.uk
Patch applied in v2.33. Thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.