Bug #73892 for Locales: Undeclared dependency on File::Slurp

# Wed Jan 11 02:42:21 2012 ANDK [...] cpan.org - Ticket created

Subject:

Undeclared dependency on File::Slurp

Download (untitled) / with headers
text/plain 164b

http://search.cpan.org/grep?release=Locales-0.25;string=File::Slurp;n=1;C=0 Teh grep reveals it is used but not declared in the Makefile.PL HTH, Thanks && Regards

# Fri Feb 10 13:32:50 2012 TODDR [...] cpan.org - Correspondence added

Download (untitled) / with headers
text/plain 458b

As of EU::MM 6.56 (2 years old), you shouldn't need to use PREREQ_PM. I've setup the deps in build_requires since the modules are not needed after build. This helps packagers do the right thing with dependencies. I also updated tests to not have to be updated by hand every version bump. They're also tolerant of dev versions. Finally, Note the META_MERGE in the end of the Makefile.PL. Can this be updated to point to the repo for this module please?

Subject:

locale.patch.txt

Download locale.patch.txt
text/plain 227k

Message body is not shown because it is too large.

# Fri Feb 10 13:32:53 2012 The RT System itself - Status changed from 'new' to 'open'

# Fri Feb 10 14:30:43 2012 TODDR [...] cpan.org - Correspondence added

Download (untitled) / with headers
text/plain 76b

my previous patch didn't include updates to manifest or the new offset file

Subject:

locale.patch.txt

Download locale.patch.txt
text/plain 225.2k

Message body is not shown because it is too large.

# Sat Feb 11 18:10:10 2012 dmuey [...] cpan.org - Correspondence added

Download (untitled) / with headers
text/plain 751b

Thanks Todd, • The tests being patched here are built dynamically so the build script would be what needs updated not the tests themselves. Since the version is written by the build tools its no trouble to simply leave it hardcoded. • The META.json and README is pretty cool but I'd like to hold off on those for now. I plan on updating my module starter config and then updating each module to use it and then put them on git hub. (i.e. once its on github it means it definitely meets a certain criteria) probably Locales.pm will first though. • The Makefile.PL 'PREREQ_PM, BUILD_REQUIRES, CONFIGURE_REQUIRES' change is great (and will probably be part of my module starter thing). Now I just need to find the time ;) Thanks again!

# Thu Mar 01 20:15:16 2012 dmuey [...] cpan.org - Correspondence added

Download (untitled) / with headers
text/plain 889b

just uploaded 0.26 that has the dependency addressed On Sat Feb 11 18:10:10 2012, DMUEY wrote: Show quoted text

> Thanks Todd, > > • The tests being patched here are built dynamically so the build > script would be what needs > updated not the tests themselves. Since the version is written by the > build tools its no trouble > to simply leave it hardcoded. > > • The META.json and README is pretty cool but I'd like to hold off on > those for now. I plan on > updating my module starter config and then updating each module to use > it and then put > them on git hub. (i.e. once its on github it means it definitely meets > a certain criteria) > probably Locales.pm will first though. > > • The Makefile.PL 'PREREQ_PM, BUILD_REQUIRES, CONFIGURE_REQUIRES' > change is great (and > will probably be part of my module starter thing). > > Now I just need to find the time ;) > > Thanks again!

# Thu Mar 01 20:15:31 2012 dmuey [...] cpan.org - Status changed from 'open' to 'resolved'