Skip Menu |
 

This queue is for tickets about the DBI-Shell CPAN distribution.

Report information
The Basics
Id: 73873
Status: resolved
Priority: 0/
Queue: DBI-Shell

People
Owner: DLAMBLEY [...] cpan.org
Requestors: bohica [...] ntlworld.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 11.95
Fixed in: (no value)

Attachments
0002-Fix-useless-localization-of-scalar-assignment.patch



Subject: Useless localization of scalar assignment at /usr/local/share/perl/5.10.1/DBI/Format.pm line 377
Download (untitled) / with headers
text/plain 279b
Using Perl 5.10.1 and running up dbi shell I get: Useless localization of scalar assignment at /usr/local/share/perl/5.10.1/DBI/Format.pm line 377. I think line 377 needs to be changed from: local( $^W = 0 ); to local( $^W ) = 0; Martin -- Martin J. Evans Wetherby, UK
Subject: 0002-Fix-useless-localization-of-scalar-assignment.patch
From ef8efc5b80c9395c01f23e5acd28bb3ee7810b54 Mon Sep 17 00:00:00 2001 From: Kent Fredric <kentnl@gentoo.org> Date: Sun, 8 Oct 2017 13:08:20 +1300 Subject: Fix useless localization of scalar assignment Bug: https://rt.cpan.org/Ticket/Display.html?id=73873 --- lib/DBI/Format.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DBI/Format.pm b/lib/DBI/Format.pm index 49cd7dd..bc985f9 100755 --- a/lib/DBI/Format.pm +++ b/lib/DBI/Format.pm @@ -374,7 +374,7 @@ sub header { sub row { my($self, $rowref) = @_; - local( $^W = 0 ); + local ($^W) = 0; my @row = @$rowref; my $fh = $self->{'fh'}; print $fh (join($self->{sep}, @row), "\n"); -- 2.14.1
Thank you for your patch! It seems to resolve the problem. I have merged it into 11.95_01.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.