Skip Menu |
 

This queue is for tickets about the POSIX-pselect CPAN distribution.

Report information
The Basics
Id: 73818
Status: open
Priority: 0/
Queue: POSIX-pselect

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.02
Fixed in: (no value)

Attachments
0001-Don-t-die-during-perl-Makefile.PL.patch



Subject: Makefile.PL dies on missing prerequisites
Download (untitled) / with headers
text/plain 390b
The Makefile.PL has a begin block that checks the availability of dependencies. It dies when some prerequisite is not installed. A comment indicates that the block is only intended for the author. Did you erroneously leave it in? In any case, please remove it, it prevents installer software to simply install the prerequisites and handle the install in the usual way, Thanks && Regards,
Download (untitled) / with headers
text/plain 478b
On Sun Jan 08 00:37:05 2012, ANDK wrote: Show quoted text
> The Makefile.PL has a begin block that checks the availability of > dependencies. It dies when some prerequisite is not installed. > > A comment indicates that the block is only intended for the author. Did > you erroneously leave it in? > > In any case, please remove it, it prevents installer software to simply > install the prerequisites and handle the install in the usual way, > > Thanks && Regards,
I concur, patch attached.
Subject: 0001-Don-t-die-during-perl-Makefile.PL.patch
From 9101d335ef5b91236ba3f1ccdbd5fc516b74280b Mon Sep 17 00:00:00 2001 From: Leon Timmermans <fawaka@gmail.com> Date: Fri, 11 May 2012 17:03:38 +0200 Subject: [PATCH 1/2] =?UTF-8?q?Don't=20die=20during=20=C2=ABperl=20Makefile.?= =?UTF-8?q?PL=C2=BB?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's perfectly ok for those deps not to be installed yet. It's not ok to kill cpan clients by dieing. --- Makefile.PL | 23 +---------------------- 1 files changed, 1 insertions(+), 22 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 024ce11..5a061b3 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,27 +1,6 @@ use strict; use warnings; -BEGIN { - unshift @INC, 'inc'; - - # author requires, or bundled modules - my @devmods = qw( - inc::Module::Install 1.00 - Module::Install::AuthorTests 0.002 - Module::Install::Repository 0.06 - Module::Install::XSUtil 0.32 - Test::Requires 0.06 - ); - my @not_available; - while(my($mod, $ver) = splice @devmods, 0, 2) { - eval qq{use $mod $ver (); 1} or push @not_available, $mod; - } - if(@not_available) { - print qq{# The following modules are not available.\n}; - print qq{# `perl $0 | cpanm` will install them:\n}; - print $_, "\n" for @not_available; - exit 1; - } -} + use inc::Module::Install; all_from 'lib/POSIX/pselect.pm'; -- 1.7.5.4


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.