Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 73288
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: t/tmpdir.t must make directories writeable before removing them
Download (untitled) / with headers
text/plain 655b
Without this change, running tests again on MSWin32 will fail because the directories are not cleaned up. This breaks p5p blead smokers, which do run tests repeatedly on the same source tree. C.f. commit eb883b9286505f2ba163b6a72b9978e9a3645b4d in blead diff --git a/cpan/CGI/t/tmpdir.t b/cpan/CGI/t/tmpdir.t index 6e3fcbd..1407356 100644 --- a/cpan/CGI/t/tmpdir.t +++ b/cpan/CGI/t/tmpdir.t @@ -37,4 +37,4 @@ isnt($CGITempFile::TMPDIRECTORY, $testdir, "unwritable \$ENV{TMPDIR} not overridden with an unwritable \$CGITempFile::TMPDIRECTORY"); } -END { rmdir for ($testdir, $testdir2) } +END { for ($testdir, $testdir2) { chmod 0700, $_; rmdir; } }
available to merge at https://github.com/markstos/CGI.pm/pull/11 -- rjbs
This was released some time ago.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.