Skip Menu |
 

This queue is for tickets about the Cairo CPAN distribution.

Report information
The Basics
Id: 73177
Status: resolved
Priority: 0/
Queue: Cairo

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.081
Fixed in: (no value)



Subject: ->show_text does not handle latin1 strings correctly
Download (untitled) / with headers
text/plain 302b
The ->show_text method does not handle codepoints > 128 in a perl string without utf8 flag correctly. See the attached sample script. A quick glance in Cairo.xs shows that SvPV is used. Probably SvPVutf8 should be used instead here to fix the problem. See also "perldoc perlapi". Regards, Slaven
Subject: cairo_non_utf8.pl
Download cairo_non_utf8.pl
text/x-perl 334b
#!/usr/bin/perl use strict; use Cairo; my $surface = Cairo::ImageSurface->create("rgb24", 300, 50); my $context = Cairo::Context->create($surface); my $text = "Test äöüß"; #utf8::upgrade($text); $context->move_to(10,10); $context->set_source_rgb(1,1,1); $context->show_text($text); $surface->write_to_png ('/tmp/test.png'); __END__
Subject: Re: [rt.cpan.org #73177] ->show_text does not handle latin1 strings correctly
Date: Sun, 11 Dec 2011 21:07:02 +0100
To: bug-Cairo [...] rt.cpan.org, gtk-perl-list [...] gnome.org
From: Torsten Schoenfeld <kaffeetisch [...] gmx.de>
Download (untitled) / with headers
text/plain 1.6k
On 11.12.2011 18:40, Slaven_Rezic via RT wrote: Show quoted text
> Sun Dec 11 12:40:59 2011: Request 73177 was acted upon. > Transaction: Ticket created by SREZIC > Queue: Cairo > Subject: ->show_text does not handle latin1 strings correctly > Broken in: 1.081 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=73177 > > > > The ->show_text method does not handle codepoints > 128 in a perl string > without utf8 flag correctly. See the attached sample script. > > A quick glance in Cairo.xs shows that SvPV is used. Probably SvPVutf8 > should be used instead here to fix the problem. See also "perldoc perlapi".
Yeah, the current implementation basically burdens the user with ensuring correct encoding. As you show in the attached program, that basically boils down to utf8::upgrade() if you have latin1-encoded strings. I agree that it would be convenient if Cairo auto-upgraded strings if utf8 is expected. But I worry about backwards-compatibility: * If someone used utf8::encode() instead of utf8::upgrade(), then auto-upgrading will lead to double encoding. * If someone used utf8 literals without specifying "use utf8", then auto-upgrading will also lead to double encoding. Technically, both these usages are incorrect. But they work OK with current Cairo and it would break if implemented auto-upgrading. What do you think? I pushed a branch to the git repo which implements the necessary changes: <http://git.gnome.org/browse/perl-Cairo/commit/?h=auto-utf8&id=f40ee313502510aedcd2df1a225fa6095717c2d2>. I also CC the mailing list for further opinions.
CC: SREZIC [...] cpan.org
Subject: Re: [rt.cpan.org #73177] ->show_text does not handle latin1 strings correctly
Date: Sun, 11 Dec 2011 22:33:39 +0100
To: bug-Cairo [...] rt.cpan.org
From: Slaven Rezic <slaven [...] rezic.de>
Download (untitled) / with headers
text/plain 2.3k
"Torsten Schoenfeld via RT" <bug-Cairo@rt.cpan.org> writes: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=73177 > > > On 11.12.2011 18:40, Slaven_Rezic via RT wrote:
>> Sun Dec 11 12:40:59 2011: Request 73177 was acted upon. >> Transaction: Ticket created by SREZIC >> Queue: Cairo >> Subject: ->show_text does not handle latin1 strings correctly >> Broken in: 1.081 >> Severity: (no value) >> Owner: Nobody >> Requestors: SREZIC@cpan.org >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=73177 > >> >> >> The ->show_text method does not handle codepoints > 128 in a perl string >> without utf8 flag correctly. See the attached sample script. >> >> A quick glance in Cairo.xs shows that SvPV is used. Probably SvPVutf8 >> should be used instead here to fix the problem. See also "perldoc perlapi".
> > Yeah, the current implementation basically burdens the user with > ensuring correct encoding. As you show in the attached program, that > basically boils down to utf8::upgrade() if you have latin1-encoded > strings. I agree that it would be convenient if Cairo auto-upgraded > strings if utf8 is expected. But I worry about backwards-compatibility: > > * If someone used utf8::encode() instead of utf8::upgrade(), then > auto-upgrading will lead to double encoding. > > * If someone used utf8 literals without specifying "use utf8", then > auto-upgrading will also lead to double encoding. > > Technically, both these usages are incorrect. But they work OK with > current Cairo and it would break if implemented auto-upgrading. > > What do you think? I pushed a branch to the git repo which implements > the necessary changes: > <http://git.gnome.org/browse/perl-Cairo/commit/?h=auto-utf8&id=f40ee313502510aedcd2df1a225fa6095717c2d2>. > I also CC the mailing list for further opinions. >
The change looks good to me (SvPVutf8 is using sv_utf8_upgrade behind the scenes, so it's more-or-less the same). About backward-compatibility: yes, things may break. But then, Cairo's cousin Pango is doing utf8-stuff already correct. So users are surprised anyway if they pass the same string to Cairo and Pango and get different results. Regards, Slaven -- Slaven Rezic - slaven <at> rezic <dot> de tktimex - time recording tool http://sourceforge.net/projects/ptktools/
The change has now been merged into git master. Thanks for the report.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.