|Subject:||Exclude pragmas from Modules::RequireExplicitPackage|
|Date:||Wed, 23 Nov 2011 12:28:25 +0000 (GMT)|
|To:||"bug-Perl-Critic [...] rt.cpan.org" <bug-Perl-Critic [...] rt.cpan.org>|
|From:||Darius Jokilehto <dariusjokilehto [...] yahoo.co.uk>|
Hello, At work we run Perl::Critic as part of our test suite, and we have recently come across an issue with Modules::RequireExplicitPackage clashing with a new version of DBIx::Class::Schema::Loader, which we use to create our DBIC schema definitions. As of version 0.07011 DBIC::SL adds a 'use utf8' pragma before the package declaration for the files it creates. As pragmas are file-scoped unless they're in curlies I would suggest excluding pragmas from the rule. I'm attaching a patch - it's created from gitpan (v1.105 of Perl::Critic), please review and let me know if I need to make any changes. Thanks, Darius
Message body is not shown because sender requested not to inline it.