Skip Menu |
 

This queue is for tickets about the RT-Extension-CommandByMail CPAN distribution.

Report information
The Basics
Id: 71958
Status: open
Priority: 0/
Queue: RT-Extension-CommandByMail

People
Owner: Nobody in particular
Requestors: tt [...] lihas.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: Christian Recktenwald <tt-comment [...] lihas.de>
Subject: [LiHAS #3069] Headers interfering with mail content / patch included
Date: Wed, 26 Oct 2011 16:09:41 +0200
To: bug-RT-Extension-CommandByMail [...] rt.cpan.org
From: Christian Recktenwald <tt [...] lihas.de>
Download (untitled) / with headers
text/plain 736b
Hi, taking great advantage of RT::Extension::CommandByMail there is one drawback: it sometimes interferes with ordinary mail content: some of our customers got "Extended mailgate error" just because they used something like: "Bug: things go wrong" in their mails. So I changed RT::Extension::CommandByMail::TakeAction.pm to expect all the commands being prefixed with "X-RT-" or ignore them otherwise. The patch is against RT-Extension-CommandByMail-0.09.tar.gz Kind regards, chris -- LiHAS - Adrian Reyer - Hessenwiesenstraße 10 - D-70565 Stuttgart Fon: +49 (7 11) 78 28 50 90 - Fax: +49 (7 11) 78 28 50 91 Mail: lihas@lihas.de - Web: http://lihas.de Linux, Netzwerke, Consulting & Support - USt-ID: DE 227 816 626 Stuttgart
Download TakeAction.diff
text/x-diff 1k

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #71958] [LiHAS #3069] Headers interfering with mail content / patch included
Date: Wed, 26 Oct 2011 10:36:42 -0400
To: bug-RT-Extension-CommandByMail [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
Download (untitled) / with headers
text/plain 503b
On 10/26/2011 10:10 AM, Christian Recktenwald via RT wrote: Show quoted text
> So I changed RT::Extension::CommandByMail::TakeAction.pm > to expect all the commands being prefixed with "X-RT-" > or ignore them otherwise. > > The patch is against RT-Extension-CommandByMail-0.09.tar.gz
This change breaks backwards compatibility. A better option would be to make the prefix configurable (defaulting to none) or the error state configurable so it's just a warning and not a fatal error. Does this make sense? Thomas
CC: Christian Recktenwald <tt-comment [...] lihas.de>
Subject: Re: [rt.cpan.org #71958] [LiHAS #3069] Headers interfering with mail content / patch included
Date: Wed, 26 Oct 2011 17:07:07 +0200
To: bug-RT-Extension-CommandByMail [...] rt.cpan.org
From: Christian Recktenwald <tt [...] lihas.de>
Download (untitled) / with headers
text/plain 550b
Show quoted text
> This change breaks backwards compatibility. A better option would be to > make the prefix configurable (defaulting to none)
Yup. I just don't have any clue how to get this one implemented. Show quoted text
> or the error state configurable so it's just a warning and not a fatal error.
less preferred here :-) -- LiHAS - Adrian Reyer - Hessenwiesenstraße 10 - D-70565 Stuttgart Fon: +49 (7 11) 78 28 50 90 - Fax: +49 (7 11) 78 28 50 91 Mail: lihas@lihas.de - Web: http://lihas.de Linux, Netzwerke, Consulting & Support - USt-ID: DE 227 816 626 Stuttgart
Subject: Re: [rt.cpan.org #71958] [LiHAS #3069] Headers interfering with mail content / patch included
Date: Wed, 26 Oct 2011 11:09:00 -0400
To: bug-RT-Extension-CommandByMail [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
Download (untitled) / with headers
text/plain 236b
On 10/26/2011 11:07 AM, Christian Recktenwald via RT wrote: Show quoted text
>> or the error state configurable so it's just a warning and not a fatal error.
> > less preferred here :-)
Well, the warning need not go the user, and I'd expect it not to.
CC: tt-comment [...] lihas.de
Subject: Re: [rt.cpan.org #71958] [LiHAS #3069] Headers interfering with mail content / patch included
Date: Wed, 26 Oct 2011 17:29:20 +0200
To: bug-RT-Extension-CommandByMail [...] rt.cpan.org
From: Christian Recktenwald <tt [...] lihas.de>
On Wed, Oct 26, 2011 at 11:09:16AM -0400, Thomas Sibley via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=71958 > > > On 10/26/2011 11:07 AM, Christian Recktenwald via RT wrote:
> >> or the error state configurable so it's just a warning and not a fatal error.
> > > > less preferred here :-)
> > Well, the warning need not go the user, and I'd expect it not to.
But, in fact, it would not be worth a warning, because nothing bad happened at all. What really happens is: someone runs into a unforseeable syntactic collision per incident which could be easily circumvented by a more robust interface design - here: disjunct namespaces by using a configurable prefix. There's a small difference between solving a problem and just supressing the related error messages. Do you agree to that? :-) -- LiHAS - Adrian Reyer - Hessenwiesenstraße 10 - D-70565 Stuttgart Fon: +49 (7 11) 78 28 50 90 - Fax: +49 (7 11) 78 28 50 91 Mail: lihas@lihas.de - Web: http://lihas.de Linux, Netzwerke, Consulting & Support - USt-ID: DE 227 816 626 Stuttgart


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.