Skip Menu |
 

This queue is for tickets about the TAP-Harness-Archive CPAN distribution.

Report information
The Basics
Id: 71937
Status: rejected
Priority: 0/
Queue: TAP-Harness-Archive

People
Owner: schwigon [...] cpan.org
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.14
Fixed in: (no value)



Subject: TAP::Harness::Archive::runtests(): Unreachable statement
Download (untitled) / with headers
text/plain 718b
In TAP::Harness::Archive::runtests() we find this code at line 238: print "\nTAP Archive created at $output_file\n" unless $self->verbosity < -1; This code will never be exercised. At this point 'verbosity' is not found at the top-level in the object. It's actually an element in the 'formatter' element of the object's data structure. What would probably be better would be either this: print "\nTAP Archive created at $output_file\n" unless $self->{formatter}->{verbosity} < -1; ... or deleting the statement altogether, on the premise that no one has ever seen the code at the end of a harness run and therefore will not be surprised when the code is deleted. Thank you very much. Jim Keenan
Download (untitled) / with headers
text/plain 1.1k
Cleaning up some RT things en passant. I just had a look here and can say that the code works as expected. It prints the message normally, avoids it when prove -Q is set. Maybe it was an issue with older versions of TAP::Harness. I'm closing this ticket here. Thanks. Steffen On Tue Oct 25 22:27:57 2011, JKEENAN wrote: Show quoted text
> In TAP::Harness::Archive::runtests() we find this code at line 238: > > print "\nTAP Archive created at $output_file\n" unless > $self->verbosity < -1; > > This code will never be exercised. At this point 'verbosity' is not > found at the top-level in the object. It's actually an element in the > 'formatter' element of the object's data structure. > > What would probably be better would be either this: > > print "\nTAP Archive created at $output_file\n" > unless $self->{formatter}->{verbosity} < -1; > > ... or deleting the statement altogether, on the premise that no one has > ever seen the code at the end of a harness run and therefore will not be > surprised when the code is deleted. > > Thank you very much. > Jim Keenan
-- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/>


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.