Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Domain-PublicSuffix CPAN distribution.

Report information
The Basics
Id: 71631
Status: resolved
Priority: 0/
Queue: Domain-PublicSuffix

People
Owner: Nobody in particular
Requestors: danny [...] rego.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: .co.im not working properly
Download (untitled) / with headers
text/plain 204b
perl -e "use Domain::PublicSuffix; print Domain::PublicSuffix->new->get_root_domain('abcdefg.co.im')->suffix;" get_root_domain returns undef in this case, even using the latest public_suffix list/config.
From: danny [...] rego.com
Download (untitled) / with headers
text/plain 581b
On Wed Oct 12 13:36:34 2011, danny6869 wrote: Show quoted text
> perl -e "use Domain::PublicSuffix; print > Domain::PublicSuffix->new->get_root_domain('abcdefg.co.im')->suffix;" > > get_root_domain returns undef in this case, even using the latest > public_suffix list/config.
I am not sure what the point of "RootEnable" is/was, but when I remove usage of it, tests still appear to pass, and it fixes the issue... # } elsif ( defined $last->{'RootEnable'} and !defined $last->{$sub} ) { } elsif ( !defined $last->{$sub} ) { ...could you perhaps clarify what the purpose of RootEnable is for?
Download (untitled) / with headers
text/plain 326b
I think the problem is not with the RootEnable test itself, but with the fact that non-TLD roots (like .co.im) are not getting flagged as RootEnable when they should be (since they're present as entities in the suffix list). The attached one-line patch seems to make things work (as I expect them to, anyway). Cheers, Gavin
Subject: Domain-PublicSuffix-0.04-more-root-enable.patch
From 4186de94870eeb603dec2bd2be36b0b7fb83a8c5 Mon Sep 17 00:00:00 2001 From: Gavin Carr <gavin@openfusion.com.au> Date: Sat, 5 May 2012 16:56:39 +1000 Subject: [PATCH] Set RootEnable on all root domains, not just top-level. --- lib/Domain/PublicSuffix.pm | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/Domain/PublicSuffix.pm b/lib/Domain/PublicSuffix.pm index 42ba4f3..4bce8f4 100755 --- a/lib/Domain/PublicSuffix.pm +++ b/lib/Domain/PublicSuffix.pm @@ -269,6 +269,7 @@ sub _parse_data_file { next if (!$sub); $last->{$sub} = {} unless ( defined $last->{$sub} ); + $last->{$sub}->{'RootEnable'} = 1 if scalar @domain_array == 0; $last = $last->{$sub}; } } -- 1.7.1
Your patch has been applied in release 0.05. Thank you!
Subject: Re: [rt.cpan.org #71631] Resolved: .co.im not working properly
Date: Tue, 30 Oct 2018 13:53:11 +0000
To: bug-domain-publicsuffix [...] rt.cpan.org
From: Danny Rego <danny [...] rego.com>
Download (untitled) / with headers
text/plain 429b
Good morning,I have a proposal for you. Please see attached and confirm. Thanks, Danny Rego  From: bug-Domain-PublicSuffix@rt.cpan.org Sent: Tue, 17 Jul 2012 21:58:46 +0000 To: danny@rego.com Subject: [rt.cpan.org #71631] Resolved: .co.im not working properly   According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message.
Download Rego.doc
application/msword 90k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #71631] Resolved: .co.im not working properly
Date: Tue, 30 Oct 2018 13:53:11 +0000
To: bug-domain-publicsuffix [...] rt.cpan.org
From: Danny Rego <danny [...] rego.com>
Download (untitled) / with headers
text/plain 429b
Good morning,I have a proposal for you. Please see attached and confirm. Thanks, Danny Rego  From: bug-Domain-PublicSuffix@rt.cpan.org Sent: Tue, 17 Jul 2012 21:58:46 +0000 To: danny@rego.com Subject: [rt.cpan.org #71631] Resolved: .co.im not working properly   According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message.
Download Rego.doc
application/msword 90k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #71631] Resolved: .co.im not working properly
Date: Tue, 30 Oct 2018 13:53:11 +0000
To: bug-domain-publicsuffix [...] rt.cpan.org
From: Danny Rego <danny [...] rego.com>
Download (untitled) / with headers
text/plain 429b
Good morning,I have a proposal for you. Please see attached and confirm. Thanks, Danny Rego  From: bug-Domain-PublicSuffix@rt.cpan.org Sent: Tue, 17 Jul 2012 21:58:46 +0000 To: danny@rego.com Subject: [rt.cpan.org #71631] Resolved: .co.im not working properly   According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message.
Download Rego.doc
application/msword 90k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #71631] Resolved: .co.im not working properly
Date: Tue, 30 Oct 2018 13:53:11 +0000
To: bug-domain-publicsuffix [...] rt.cpan.org
From: Danny Rego <danny [...] rego.com>
Download (untitled) / with headers
text/plain 429b
Good morning,I have a proposal for you. Please see attached and confirm. Thanks, Danny Rego  From: bug-Domain-PublicSuffix@rt.cpan.org Sent: Tue, 17 Jul 2012 21:58:46 +0000 To: danny@rego.com Subject: [rt.cpan.org #71631] Resolved: .co.im not working properly   According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message.
Download Rego.doc
application/msword 90k

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.