Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 71523
Status: open
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: IKEGAMI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Add test_requires and test_recommends
Download (untitled) / with headers
text/plain 268b
There's no good way to specify optional modules for tests, so tests are getting skipped left and right in just about every distro. I would like support for test_requires and test_recommends. Patch pushed to git repo: https://github.com/dagolden/module-build/pull/16
Download (untitled) / with headers
text/plain 120b
Thank you, but I'd like to defer this until there is better CPAN::Meta v2 support and consider it together at that time.
Download (untitled) / with headers
text/plain 477b
Perl has a pretty long history of treating testing as an integral part of building. It's served the community quite well in lots of ways. That's why there's been no test_requires and test_recommends - because it's considered part of build_requires and build_recommends. I'm not sure it's a good idea to change it, both for back-compatibility reasons and because it seems like it might be a step backwards unless there's some other really compelling reason to want it. -Ken
CC: IKEGAMI [...] cpan.org
Subject: Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date: Fri, 4 Nov 2011 18:55:08 -0400
To: bug-Module-Build [...] rt.cpan.org
From: Eric Brine <ikegami [...] adaelis.com>
Download (untitled) / with headers
text/plain 571b
On Fri, Nov 4, 2011 at 3:08 PM, Ken Williams via RT < bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=71523 > > > Perl has a pretty long history of treating testing as an integral part > of building. It's served the community quite well in lots of ways. >
Show quoted text
> That's why there's been no test_requires and test_recommends - because > it's considered part of build_requires and build_recommends.
Except there's no build_recommends either. Are you open to accepting a patch to add build_recommends, or would that get deferred too?
Download (untitled) / with headers
text/plain 344b
On Fri Nov 04 18:55:17 2011, ikegami@adaelis.com wrote: Show quoted text
> Except there's no build_recommends either. Are you open to accepting a > patch to add build_recommends, or would that get deferred too?
I think a build_recommends would be a good idea. I guess I forgot it didn't already exist. I'd defer to David's sense about when to add it though.
CC: IKEGAMI [...] cpan.org
Subject: Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date: Sat, 5 Nov 2011 02:54:28 -0400
To: bug-Module-Build [...] rt.cpan.org
From: Eric Brine <ikegami [...] adaelis.com>
Download (untitled) / with headers
text/plain 610b
On Sat, Nov 5, 2011 at 12:41 AM, Ken Williams via RT < bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=71523 > > > On Fri Nov 04 18:55:17 2011, ikegami@adaelis.com wrote:
> > Except there's no build_recommends either. Are you open to accepting a > > patch to add build_recommends, or would that get deferred too?
> > I think a build_recommends would be a good idea. I guess I forgot it > didn't already exist. I'd > defer to David's sense about when to add it though. >
On the off chance, patch submitted via github: https://github.com/dagolden/module-build/pull/19
Subject: Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date: Sat, 5 Nov 2011 07:08:32 -0400
To: bug-Module-Build [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 590b
On Sat, Nov 5, 2011 at 12:41 AM, Ken Williams via RT <bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> I think a build_recommends would be a good idea.  I guess I forgot it didn't already exist.  I'd > defer to David's sense about when to add it though.
At the moment, none of the CPAN clients to my knowledge do anything with recommends. So, while visual warnings are nice, the real change needed is for M::B to spit out version 2 MYMETA files and for the CPAN clients to use those to actually honor recommends, etc. That might have to be my QA hackathon project for the spring. :-) -- David
CC: IKEGAMI [...] cpan.org
Subject: Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date: Sat, 5 Nov 2011 21:15:05 -0400
To: bug-Module-Build [...] rt.cpan.org
From: Eric Brine <ikegami [...] adaelis.com>
Download (untitled) / with headers
text/plain 791b
On Sat, Nov 5, 2011 at 2:54 AM, Eric Brine <ikegami@adaelis.com> wrote: Show quoted text
> On Sat, Nov 5, 2011 at 12:41 AM, Ken Williams via RT < > bug-Module-Build@rt.cpan.org> wrote: >
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=71523 > >> >> On Fri Nov 04 18:55:17 2011, ikegami@adaelis.com wrote:
>> > Except there's no build_recommends either. Are you open to accepting a >> > patch to add build_recommends, or would that get deferred too?
>> >> I think a build_recommends would be a good idea. I guess I forgot it >> didn't already exist. I'd >> defer to David's sense about when to add it though. >>
> > On the off chance, patch submitted via github: > https://github.com/dagolden/module-build/pull/19 > >
Resubmitted to new repo. https://github.com/Perl-Toolchain-Gang/Module-Build/pull/1


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.