Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 71403
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: kevin [...] ie.suberic.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: c [...] ie.suberic.net
Date: Sun, 2 Oct 2011 23:23:38 +0100 (BST)
To: bug-xml-libxml [...] rt.cpan.org, kevin [...] ie.suberic.net
From: kevin [...] ie.suberic.net (Kevin Lyda)
Download (untitled) / with headers
text/plain 3.8k
A number of spelling fixes. Most are in comments, one is in the docs. diff -r db1463c94247 -r fbc0b56511cc lib/XML/LibXML/SAX/Parser.pm --- a/lib/XML/LibXML/SAX/Parser.pm Wed Sep 21 12:58:37 2011 +0300 +++ b/lib/XML/LibXML/SAX/Parser.pm Sun Oct 02 23:20:02 2011 +0100 @@ -121,7 +121,7 @@ elsif ($node_type == XML_DOCUMENT_NODE || $node_type == XML_HTML_DOCUMENT_NODE || $node_type == XML_DOCUMENT_FRAG_NODE) { - # some times it is just usefull to generate SAX events from + # some times it is just useful to generate SAX events from # a document fragment (very good with filters). foreach my $kid ($node->childNodes) { $self->process_node($kid); diff -r db1463c94247 -r fbc0b56511cc perl-libxml-mm.h --- a/perl-libxml-mm.h Wed Sep 21 12:58:37 2011 +0300 +++ b/perl-libxml-mm.h Sun Oct 02 23:20:02 2011 +0100 @@ -302,7 +302,7 @@ * * DESCRIPTION * creates an Gdome node from our XML::LibXML node. - * this function is very usefull for the parser. + * this function is very useful for the parser. * * the function will only work, if XML::LibXML is compiled with * XML::GDOME support. diff -r db1463c94247 -r fbc0b56511cc perl-libxml-sax.c --- a/perl-libxml-sax.c Wed Sep 21 12:58:37 2011 +0300 +++ b/perl-libxml-sax.c Sun Oct 02 23:20:02 2011 +0100 @@ -87,7 +87,7 @@ static U32 SystemIdHash; /* helper function C2Sv is ment to work faster than the perl-libxml-mm - version. this shortcut is usefull, because SAX handles only UTF8 + version. this shortcut is useful, because SAX handles only UTF8 strings, so there is no conversion logic required. */ SV* diff -r db1463c94247 -r fbc0b56511cc t/02parse.t --- a/t/02parse.t Wed Sep 21 12:58:37 2011 +0300 +++ b/t/02parse.t Sun Oct 02 23:20:02 2011 +0100 @@ -235,7 +235,7 @@ my $re = qr/\ACould not create file parser context for file "\Q$badfile2\E": \Q$err_string\E/; eval { $parser->parse_file($badfile2); }; - like($@, $re, "error parsing non-existant $badfile2"); + like($@, $re, "error parsing non-existent $badfile2"); } { @@ -267,7 +267,7 @@ $fh = IO::File->new($badfile2); eval { my $doc = $parser->parse_fh($fh); }; -like($@, qr/^Can't use an undefined value as a symbol reference at/, "error parsing bad file from file handle of non-existant $badfile2"); +like($@, qr/^Can't use an undefined value as a symbol reference at/, "error parsing bad file from file handle of non-existent $badfile2"); { $parser->expand_entities(1); diff -r db1463c94247 -r fbc0b56511cc t/42common.t --- a/t/42common.t Wed Sep 21 12:58:37 2011 +0300 +++ b/t/42common.t Sun Oct 02 23:20:02 2011 +0100 @@ -83,7 +83,7 @@ ok (!defined(decodeFromUTF8( 'UTF-16' , undef )), 'decodeFromUTF8 of undef.'); # here should be a test to test badly encoded strings. but for some -# reasons i am unable to create an apropriate test :( +# reasons i am unable to create an appropriate test :( # uncomment these lines if your system is capable to handel not only i # so latin 1 diff -r db1463c94247 -r fbc0b56511cc xpath.c --- a/xpath.c Wed Sep 21 12:58:37 2011 +0300 +++ b/xpath.c Sun Oct 02 23:20:02 2011 +0100 @@ -178,7 +178,7 @@ if ( refNode->doc == NULL ) { /* if one XPaths a node from a fragment, libxml2 will - refuse the lookup. this is not very usefull for XML + refuse the lookup. this is not very useful for XML scripters. thus we need to create a temporary document to make libxml2 do it's job correctly. */ @@ -332,7 +332,7 @@ if ( ctxt->node->doc == NULL ) { /* if one XPaths a node from a fragment, libxml2 will - refuse the lookup. this is not very usefull for XML + refuse the lookup. this is not very useful for XML scripters. thus we need to create a temporary document to make libxml2 do it's job correctly. */
Download (untitled) / with headers
text/plain 4.3k
On Sun Oct 02 18:23:48 2011, kevin@ie.suberic.net wrote: Show quoted text
> A number of spelling fixes. Most are in comments, one is in the docs. >
Applied, thanks. I also corrected "some times" to "sometimes". This patch is in the repository and will be released in the upcoming CPAN version. Regards, — Shlomi Fish Show quoted text
> diff -r db1463c94247 -r fbc0b56511cc lib/XML/LibXML/SAX/Parser.pm > --- a/lib/XML/LibXML/SAX/Parser.pm Wed Sep 21 12:58:37 2011 +0300 > +++ b/lib/XML/LibXML/SAX/Parser.pm Sun Oct 02 23:20:02 2011 +0100 > @@ -121,7 +121,7 @@ > elsif ($node_type == XML_DOCUMENT_NODE > || $node_type == XML_HTML_DOCUMENT_NODE > || $node_type == XML_DOCUMENT_FRAG_NODE) { > - # some times it is just usefull to generate SAX events from > + # some times it is just useful to generate SAX events from > # a document fragment (very good with filters). > foreach my $kid ($node->childNodes) { > $self->process_node($kid); > diff -r db1463c94247 -r fbc0b56511cc perl-libxml-mm.h > --- a/perl-libxml-mm.h Wed Sep 21 12:58:37 2011 +0300 > +++ b/perl-libxml-mm.h Sun Oct 02 23:20:02 2011 +0100 > @@ -302,7 +302,7 @@ > * > * DESCRIPTION > * creates an Gdome node from our XML::LibXML node. > - * this function is very usefull for the parser. > + * this function is very useful for the parser. > * > * the function will only work, if XML::LibXML is compiled with > * XML::GDOME support. > diff -r db1463c94247 -r fbc0b56511cc perl-libxml-sax.c > --- a/perl-libxml-sax.c Wed Sep 21 12:58:37 2011 +0300 > +++ b/perl-libxml-sax.c Sun Oct 02 23:20:02 2011 +0100 > @@ -87,7 +87,7 @@ > static U32 SystemIdHash; > > /* helper function C2Sv is ment to work faster than the perl-libxml- > mm > - version. this shortcut is usefull, because SAX handles only UTF8 > + version. this shortcut is useful, because SAX handles only UTF8 > strings, so there is no conversion logic required. > */ > SV* > diff -r db1463c94247 -r fbc0b56511cc t/02parse.t > --- a/t/02parse.t Wed Sep 21 12:58:37 2011 +0300 > +++ b/t/02parse.t Sun Oct 02 23:20:02 2011 +0100 > @@ -235,7 +235,7 @@ > my $re = qr/\ACould not create file parser context for file > "\Q$badfile2\E": \Q$err_string\E/; > > eval { $parser->parse_file($badfile2); }; > - like($@, $re, "error parsing non-existant $badfile2"); > + like($@, $re, "error parsing non-existent $badfile2"); > } > > { > @@ -267,7 +267,7 @@ > $fh = IO::File->new($badfile2); > > eval { my $doc = $parser->parse_fh($fh); }; > -like($@, qr/^Can't use an undefined value as a symbol reference at/, > "error parsing bad file from file handle of non-existant $badfile2"); > +like($@, qr/^Can't use an undefined value as a symbol reference at/, > "error parsing bad file from file handle of non-existent $badfile2"); > > { > $parser->expand_entities(1); > diff -r db1463c94247 -r fbc0b56511cc t/42common.t > --- a/t/42common.t Wed Sep 21 12:58:37 2011 +0300 > +++ b/t/42common.t Sun Oct 02 23:20:02 2011 +0100 > @@ -83,7 +83,7 @@ > ok (!defined(decodeFromUTF8( 'UTF-16' , undef )), 'decodeFromUTF8 of > undef.'); > > # here should be a test to test badly encoded strings. but for some > -# reasons i am unable to create an apropriate test :( > +# reasons i am unable to create an appropriate test :( > > # uncomment these lines if your system is capable to handel not only > i > # so latin 1 > diff -r db1463c94247 -r fbc0b56511cc xpath.c > --- a/xpath.c Wed Sep 21 12:58:37 2011 +0300 > +++ b/xpath.c Sun Oct 02 23:20:02 2011 +0100 > @@ -178,7 +178,7 @@ > > if ( refNode->doc == NULL ) { > /* if one XPaths a node from a fragment, libxml2 will > - refuse the lookup. this is not very usefull for XML > + refuse the lookup. this is not very useful for XML > scripters. thus we need to create a temporary document > to make libxml2 do it's job correctly. > */ > @@ -332,7 +332,7 @@ > > if ( ctxt->node->doc == NULL ) { > /* if one XPaths a node from a fragment, libxml2 will > - refuse the lookup. this is not very usefull for XML > + refuse the lookup. this is not very useful for XML > scripters. thus we need to create a temporary document > to make libxml2 do it's job correctly. > */


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.