|Subject:||Useless module check in self-test|
|Date:||Fri, 16 Sep 2011 18:43:26 -0400|
|From:||"Daniel Macks" <email@example.com>|
Building CPAN-1.9800 without activating AUTHOR_TEST (i.e., the way a normal user or sysadmin would do it) gives a diagnostic during 'make test': t/70_critic.t .......... skipped: Test::Perl::Critic required to criticise code So I install this module (along with its fairly substantial dependency tree), only to find that now that message becomes: t/70_critic.t .......... skipped: Test::Perl::Critic only run when AUTHOR_TEST set The test isn't even going to be run and I didn't need to install all that extra stuff! Seems more sensible to switch the order of these two checks. That is, *first* check if AUTHOR_TEST has been requested, and then only if so do the check for the dependencies necessary to do it. Attached patch switches this ordering: dan -- Daniel Macks firstname.lastname@example.org
Message body is not shown because sender requested not to inline it.