This queue is for tickets about the DateTime-Format-Roman CPAN distribution.

Report information
The Basics
Id:
69845
Status:
resolved
Priority:
Low/Low

People
Owner:
J2N-FORGET [...] orange.fr
Requestors:
J2N-FORGET [...] orange.fr
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
0.03
Fixed in:
0.04



Subject: Warning about DateTime::Local deprecated methods
Warnings about "month_names" and "month_abbreviations" methods, which are deprecated in the recent releases of DateTime::Locale. The attached patch fixes these warnings.
Subject: dt-f-roman.patch
diff -ru DateTime-Format-Roman-0.03/Changes DateTime-Format-Roman-0.04/Changes --- DateTime-Format-Roman-0.03/Changes 2004-10-18 18:38:12.000000000 +0200 +++ DateTime-Format-Roman-0.04/Changes 2011-07-27 20:27:13.853875126 +0200 @@ -1,5 +1,8 @@ Revision history for Perl module DateTime::Format::Roman +0.04 ?? mmxi + - remove the warning about the month_abbreviations method + 0.03 xv kal nov anno mmiv - added default pattern - format_datetime() can nnow be used as a class method diff -ru DateTime-Format-Roman-0.03/lib/DateTime/Format/Roman.pm DateTime-Format-Roman-0.04/lib/DateTime/Format/Roman.pm --- DateTime-Format-Roman-0.03/lib/DateTime/Format/Roman.pm 2004-10-18 18:35:36.000000000 +0200 +++ DateTime-Format-Roman-0.04/lib/DateTime/Format/Roman.pm 2011-07-27 20:34:20.953992382 +0200 @@ -4,7 +4,7 @@ use vars qw($VERSION); -$VERSION = 0.03; +$VERSION = 0.04; use DateTime 0.22; @@ -33,8 +33,8 @@ my %dt_elem; my %formats; %formats = - ( 'b' => sub { (shift->language->month_abbreviations)->[$dt_elem{month}-1] }, - 'B' => sub { (shift->language->month_names)->[$dt_elem{month}-1] }, + ( 'b' => sub { (shift->language->month_format_abbreviated)->[$dt_elem{month}-1] }, + 'B' => sub { (shift->language->month_format_wide) ->[$dt_elem{month}-1] }, 'd' => sub { $dt_elem{day} }, 'D' => sub { ($dt_elem{day} ne 1 && $dt_elem{day}.' ') . $formats{f}->(@_) }, 'f' => sub { $fixed_days_names[$_[1]||0]{$dt_elem{fixed_day}} },
Le Mer 27 Jui 2011 15:44:35, JFORGET a écrit :
Show quoted text
> Warnings about "month_names" and "month_abbreviations" methods, > which are deprecated in the recent releases of DateTime::Locale. > The attached patch fixes these warnings.
Something is missing from the patch: Makefile.PL should contain a prereq to DateTime::Locale, with the proper version number.
On 2011-07-27 15:44:35, JFORGET wrote:
Show quoted text
> Warnings about "month_names" and "month_abbreviations" methods, > which are deprecated in the recent releases of DateTime::Locale. > The attached patch fixes these warnings.
In recent DateTime::Locale versions at least month_names is removed: Can't locate object method "month_names" via package "DateTime::Locale::FromData" at /tmpfs/.cpan-build/2015112215/DateTime-Format-Roman-0.03-pC9Xtt/blib/lib/DateTime/Format/Roman.pm line 37. # Looks like your test exited with 255 before it could output anything. t/003_format.t ... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/4 subtests Can't locate object method "month_names" via package "DateTime::Locale::FromData" at /tmpfs/.cpan-build/2015112215/DateTime-Format-Roman-0.03-pC9Xtt/blib/lib/DateTime/Format/Roman.pm line 37. # Looks like your test exited with 255 before it could output anything. t/004_default.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/4 subtests
Subject: Re: [rt.cpan.org #69845] Warning about DateTime::Local deprecated methods
Date: Wed, 25 Nov 2015 07:33:46 +0100
To: bug-DateTime-Format-Roman@rt.cpan.org
From: Jean Forget <J2N-FORGET@orange.fr>
Le dimanche 22 novembre 2015 à 10:39 -0500, Slaven_Rezic via RT a écrit :
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=69845 > > > On 2011-07-27 15:44:35, JFORGET wrote:
> > Warnings about "month_names" and "month_abbreviations" methods, > > which are deprecated in the recent releases of DateTime::Locale. > > The attached patch fixes these warnings.
> > In recent DateTime::Locale versions at least month_names is removed: > > Can't locate object method "month_names" via package "DateTime::Locale::FromData" at /tmpfs/.cpan-build/2015112215/DateTime-Format-Roman-0.03-pC9Xtt/blib/lib/DateTime/Format/Roman.pm line 37. > # Looks like your test exited with 255 before it could output anything. > t/003_format.t ... > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 4/4 subtests > Can't locate object method "month_names" via package "DateTime::Locale::FromData" at /tmpfs/.cpan-build/2015112215/DateTime-Format-Roman-0.03-pC9Xtt/blib/lib/DateTime/Format/Roman.pm line 37. > # Looks like your test exited with 255 before it could output anything. > t/004_default.t .. > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 4/4 subtests >
Thank you for your mail, but I am only the bug reporter, I am not the maintainer / co-maintener of the module. Of course, all modules for which I sent a patch are installed on my home machine with this patch, so I do not notice this error message. Jean Forget
Fixed on GitHub : https://github.com/jforget/DateTime-Format-Roman but not yet on CPAN. Jean Forget
Le Mar 13 Nov 2018 07:55:16, JFORGET a écrit :
Show quoted text
> Fixed on GitHub : > https://github.com/jforget/DateTime-Format-Roman > but not yet on CPAN. > > Jean Forget
Now fixed on CPAN Jean Forget


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.