Skip Menu |
 

This queue is for tickets about the MooseX-Storage CPAN distribution.

Report information
The Basics
Id: 69811
Status: resolved
Priority: 0/
Queue: MooseX-Storage

People
Owner: Nobody in particular
Requestors: CARNIL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: No need to depend on Digest::SHA1
Date: Tue, 26 Jul 2011 10:56:54 +0200
To: bug-MooseX-Storage [...] rt.cpan.org
From: Salvatore Bonaccorso <carnil [...] cpan.org>
Download (untitled) / with headers
text/plain 498b
Hi Digest::HMAC changed to use not anymore Digest::SHA1. MooseX::Storage was depending on Digest::SHA1 for Digest::HMAC? I cannot find any reference in the code which uses directly Digest::SHA1. If I'm correctly, could you drop the dependency on Digest::SHA1? Digest::SHA is in perl core since 5.9.3 and it has quite identical interface as Digest::SHA1, it defaults to SHA1 and furthermore this would be reducing the external dependencies by one. Could you apply this change? Regards Salvatore
Subject: Re: [rt.cpan.org #69811] AutoReply: No need to depend on Digest::SHA1
Date: Mon, 15 Aug 2011 21:43:41 +0200
To: Bugs in MooseX-Storage via RT <bug-MooseX-Storage [...] rt.cpan.org>
From: Salvatore Bonaccorso <carnil [...] debian.org>
Download (untitled) / with headers
text/plain 111b
Hi Here is a possible patch for this. It simply substitutes the algorithm name with SHA-1. Regards Salvatore

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Applied in commit 7d5ab5, will be in the next release. Thanks for the patch!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.