Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 69622
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: VKON [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.75
Fixed in: (no value)



Download (untitled) / with headers
text/plain 483b
starting from 1.75 version there is this chunk of code in "perl-libxml-sax.c" file, in several functions, which cause trouble: .... if (sax->joinchars) { PSaxCharactersFlush(ctxt, sax->charbuf); } dSP; .... The problem is that the file is C (as opposed to C++) and you're only allowed to declare something before any code, and declaration "dSP;" happens to be after the "if" statement. Moving the "if" after "dSP;" looks more consistent. Regards, Vadim.
Download (untitled) / with headers
text/plain 831b
Hi Vadim, On Wed Jul 20 11:49:06 2011, VKON wrote: Show quoted text
> starting from 1.75 version there is this chunk of code in > "perl-libxml-sax.c" file, in several functions, which cause trouble: > > .... > if (sax->joinchars) > { > PSaxCharactersFlush(ctxt, sax->charbuf); > } > > dSP; > .... > > The problem is that the file is C (as opposed to C++) and you're only > allowed to declare something before any code, and declaration "dSP;" > happens to be after the "if" statement. > > Moving the "if" after "dSP;" looks more consistent. >
thanks for your report. This was fixed in the bitbucket repository and will be released soon. It took me more time than usual because ssh was broken in Mandriva Cooker when the nscd daemon was running due to a glibc upgrade. You have been credited. Regards, -- Shlomi Fish
Download (untitled) / with headers
text/plain 539b
I've downloaded freshly released XML-LibXML-1.82 and, while indeed some such places are fixed, it still has such a problem in 3 more places: perl-libxml-sax.c(1109) : error C2275: 'SV' : illegal use of this type as an expression .... perl-libxml-sax.c(1154) : error C2275: 'SV' : illegal use of this type as an expression .... perl-libxml-sax.c(1221) : error C2275: 'SV' : illegal use of this type as an expression I do see that the problem was resolved in other 3 or 4 functions in that file Thanks for quick reply and resolution, BTW.
Download (untitled) / with headers
text/plain 830b
On Thu Jul 21 03:51:20 2011, VKON wrote: Show quoted text
> I've downloaded freshly released XML-LibXML-1.82 and, while indeed some > such places are fixed, it still has such a problem in 3 more places: > > perl-libxml-sax.c(1109) : error C2275: 'SV' : illegal use of this type > as an expression > .... > perl-libxml-sax.c(1154) : error C2275: 'SV' : illegal use of this type > as an expression > .... > perl-libxml-sax.c(1221) : error C2275: 'SV' : illegal use of this type > as an expression > > I do see that the problem was resolved in other 3 or 4 functions in that > file > > Thanks for quick reply and resolution, BTW.
Hi, this time I fixed it and verified this was the case everywhere by adding the flags "-Wdeclaration-after-statement -Werror" to "CCFLAGS" in the makefile. I will release it to CPAN soon. Regards, Shlomi Fish
Resolved in the repository. Will be uploaded to CPAN soon.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.