Skip Menu |
 

This queue is for tickets about the YUM-RepoQuery CPAN distribution.

Report information
The Basics
Id: 69126
Status: resolved
Priority: 0/
Queue: YUM-RepoQuery

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.1.2
Fixed in: (no value)

Attachments
perl-YUM-RepoQuery-0.1.2-Pass-bunzip2-output-argument-as-file-name-string.patch



Subject: bunzip2 does not expext second argument being Path::Class::File object
Download (untitled) / with headers
text/plain 1.1k
Live network test fails with: t/02.live.t .. 1/23 Not Found at /tmp/YUM-RepoQuery-0.1.2/blib/lib/YUM/RepoQuery.pm line 174 YUM::RepoQuery::_fetch('YUM::RepoQuery=HASH(0xc85300)', 'http://mirrors.kernel.org/fedora/updates/9/SRPMS.newkey/repod...') called at /tmp/YUM-RepoQuery-0.1.2/blib/lib/YUM/RepoQuery.pm line 79 YUM::RepoQuery::_build_repomd('YUM::RepoQuery=HASH(0xc85300)') called at reader YUM::RepoQuery::repomd (defined at /tmp/YUM-RepoQuery-0.1.2/blib/lib/YUM/RepoQuery.pm line 69) line 7 YUM::RepoQuery::repomd('YUM::RepoQuery=HASH(0xc85300)') called at /tmp/YUM-RepoQuery-0.1.2/blib/lib/YUM/RepoQuery.pm line 138 YUM::RepoQuery::_fetch_db('YUM::RepoQuery=HASH(0xc85300)', 'primary') called at /tmp/YUM-RepoQuery-0.1.2/blib/lib/YUM/RepoQuery.pm line 90 YUM::RepoQuery::_build_primary('YUM::RepoQuery=HASH(0xc85300)') called at reader YUM::RepoQuery::primary (defined at /tmp/YUM-RepoQuery-0.1.2/blib/lib/YUM/RepoQuery.pm line 86) line 7 YUM::RepoQuery::primary('YUM::RepoQuery=HASH(0xc85300)') called at t/02.live.t line 21 This due to bunzip2 function gets Path::Class:File object instead of file name string. Attached patch fixes it.
Subject: perl-YUM-RepoQuery-0.1.2-Pass-bunzip2-output-argument-as-file-name-string.patch
From 86307acc8e76489dd1bdbe80e5116e9615a49254 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 28 Jun 2011 17:34:34 +0200 Subject: [PATCH 2/2] Pass bunzip2 output argument as file name string --- lib/YUM/RepoQuery.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/YUM/RepoQuery.pm b/lib/YUM/RepoQuery.pm index 66573ea..070f4b4 100644 --- a/lib/YUM/RepoQuery.pm +++ b/lib/YUM/RepoQuery.pm @@ -150,7 +150,7 @@ sub _fetch_db { my $db_cache = $self->_fetch($db_loc_uri); # and write out, bunzip2ing as we go... - bunzip2 \$db_cache => $db_fn + bunzip2 \$db_cache => "$db_fn" or confess "bunzip2 error: $IO::Uncompress::Bzip2::Bunzip2error"; } -- 1.7.5.4
Download (untitled) / with headers
text/plain 148b
Resolved in 0.002 Incidentally, if you want to fork and submit a pull request on github, I'll almost certainly be faster in fixing these things :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.