Skip Menu |
 

This queue is for tickets about the DBD-SQLite CPAN distribution.

Report information
The Basics
Id: 68985
Status: resolved
Priority: 0/
Queue: DBD-SQLite

People
Owner: Nobody in particular
Requestors: drh [...] sqlite.org
h.m.brand [...] xs4all.nl
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: sqlite-users [...] sqlite.org
Subject: Re: [PATCH] Won't compile on archaic OS
Date: Tue, 21 Jun 2011 13:29:41 +0200
To: "Bugs in DBD-SQLite via RT" <bug-DBD-SQLite [...] rt.cpan.org>
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
Download (untitled) / with headers
text/plain 2.7k
On Mon, 23 May 2011 18:45:14 +0200, "Bugs in DBD-SQLite via RT" <bug-DBD-SQLite@rt.cpan.org> wrote: Show quoted text
This (rather clear) bug report neither got any acknowledgement, not does it appear in the RT trackers. Meanwhile things got even worse. Show quoted text
> Using gcc-3.4.6 on HP-UX 10.20:
HP-UX 10.20 does not have pread at all. -UUSE_PREAD doesn't work (enough) as the test is (very) wrong. SQLITE_ENABLE_LOCKING_STYLE is overruled in this section when passed as -USQLITE_ENABLE_LOCKING_STYLE --8<--- line 23983 #if !defined(SQLITE_ENABLE_LOCKING_STYLE) # if defined(__APPLE__) # define SQLITE_ENABLE_LOCKING_STYLE 1 # else # define SQLITE_ENABLE_LOCKING_STYLE 0 # endif #endif -->8--- And thus leaving --8<--- line 24453 #if defined(USE_PREAD) || defined(SQLITE_ENABLE_LOCKING_STYLE) { "pread", (sqlite3_syscall_ptr)pread, 0 }, #else { "pread", (sqlite3_syscall_ptr)0, 0 }, #endif -->8--- a useless and bogus test. That second test (also for pwrite) should either test for the *content* of SQLITE_ENABLE_LOCKING_STYLE or not test on it at all Show quoted text
> > make test
> gcc -c -I. -I/opt/perl/lib/site_perl/5.14.0/PA-RISC2.0/auto/DBI -mpa- > risc-1-1 -DPERL_DONT_CREATE_GVSV -D_HPUX_SOURCE -fno-strict-aliasing - > pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION= > \"1.31\" -DXS_VERSION=\"1.31\" -fPIC "-I/opt/perl/lib/5.14.0/PA-RISC2.0/ > CORE" -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS - > DSQLITE_ENABLE_COLUMN_METADATA -DNDEBUG=1 -DHAVE_USLEEP=1 - > DTHREADSAFE=0 -DSQLITE_OMIT_LOAD_EXTENSION sqlite3.c > sqlite3.c: In function `unixShmMap': > sqlite3.c:26184: error: `MAP_FAILED' undeclared (first use in this > function) > sqlite3.c:26184: error: (Each undeclared identifier is reported only > once > sqlite3.c:26184: error: for each function it appears in.) > > After applying this patch: > --8<--- > --- sqlite3.c.org 2011-05-23 15:27:35 +0200 > +++ sqlite3.c 2011-05-23 15:29:55 +0200 > @@ -22661,6 +22661,10 @@ struct unixFile { > */ > #define SQLITE_WHOLE_FILE_LOCKING 0x0001 /* Use whole-file locking */ > > +#ifndef MAP_FAILED > +#define MAP_FAILED ((void *) -1) > +#endif > + > /* > ** Include code that is common to all os_*.c files > */ > -->8--- >
> > make test
> : > All tests successful. > Files=59, Tests=1308, 87 wallclock secs ( 4.61 usr 0.48 sys + 53.42 > cusr 3.96 csys = 62.47 CPU) > Result: PASS
> >
-- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using 5.00307 through 5.14 and porting perl5.15.x on HP-UX 10.20, 11.00, 11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.4 and AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Subject: Re: [rt.cpan.org #68985] Re: [PATCH] Won't compile on archaic OS
Date: Tue, 21 Jun 2011 10:50:09 -0700
To: bug-DBD-SQLite [...] rt.cpan.org, "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
From: Darren Duncan <darren [...] darrenduncan.net>
h.m.brand@xs4all.nl via RT wrote: Show quoted text
> Tue Jun 21 07:29:52 2011: Request 68985 was acted upon. > Transaction: Ticket created by h.m.brand@xs4all.nl > Queue: DBD-SQLite > Subject: Re: [PATCH] Won't compile on archaic OS > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: h.m.brand@xs4all.nl > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=68985 > > > On Mon, 23 May 2011 18:45:14 +0200, "Bugs in DBD-SQLite via RT" > <bug-DBD-SQLite@rt.cpan.org> wrote: > > > This (rather clear) bug report neither got any acknowledgement, not > does it appear in the RT trackers. > > Meanwhile things got even worse.
H.Merijn, this ticket was *so* acknowledged, and promptly. Go see the url you provided and look at the responses to the ticket. The ticket was rejected because you need to file with the upstream. The issue is in SQLite itself, not in the Perl bridge to it. See http://sqlite.org/ about how to contact the SQLite team. -- Darren Duncan
CC: Bugs in DBD-SQLite via RT <bug-DBD-SQLite [...] rt.cpan.org>
Subject: Re: [sqlite] [PATCH] Won't compile on archaic OS
Date: Wed, 22 Jun 2011 07:48:17 -0400
To: General Discussion of SQLite Database <sqlite-users [...] sqlite.org>
From: Richard Hipp <drh [...] sqlite.org>
Download (untitled) / with headers
text/plain 3.3k
On Tue, Jun 21, 2011 at 7:29 AM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote: Show quoted text
> On Mon, 23 May 2011 18:45:14 +0200, "Bugs in DBD-SQLite via RT" > <bug-DBD-SQLite@rt.cpan.org> wrote: > > > This (rather clear) bug report neither got any acknowledgement, not > does it appear in the RT trackers. >
The problem was fixed in SQLite on 2011-04-15 with this check-in: http://www.sqlite.org/src/ci/8775f159c1 Show quoted text
> > Meanwhile things got even worse. >
> > Using gcc-3.4.6 on HP-UX 10.20:
> > HP-UX 10.20 does not have pread at all. -UUSE_PREAD doesn't work > (enough) as the test is (very) wrong. SQLITE_ENABLE_LOCKING_STYLE is > overruled in this section when passed as -USQLITE_ENABLE_LOCKING_STYLE > > --8<--- line 23983 > #if !defined(SQLITE_ENABLE_LOCKING_STYLE) > # if defined(__APPLE__) > # define SQLITE_ENABLE_LOCKING_STYLE 1 > # else > # define SQLITE_ENABLE_LOCKING_STYLE 0 > # endif > #endif > -->8--- > > And thus leaving > --8<--- line 24453 > #if defined(USE_PREAD) || defined(SQLITE_ENABLE_LOCKING_STYLE) > { "pread", (sqlite3_syscall_ptr)pread, 0 }, > #else > { "pread", (sqlite3_syscall_ptr)0, 0 }, > #endif > -->8--- > > a useless and bogus test. > > That second test (also for pwrite) should either test for the *content* > of SQLITE_ENABLE_LOCKING_STYLE or not test on it at all >
> > > make test
> > gcc -c -I. -I/opt/perl/lib/site_perl/5.14.0/PA-RISC2.0/auto/DBI -mpa- > > risc-1-1 -DPERL_DONT_CREATE_GVSV -D_HPUX_SOURCE -fno-strict-aliasing - > > pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION= > > \"1.31\" -DXS_VERSION=\"1.31\" -fPIC "-I/opt/perl/lib/5.14.0/PA-RISC2.0/ > > CORE" -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS - > > DSQLITE_ENABLE_COLUMN_METADATA -DNDEBUG=1 -DHAVE_USLEEP=1 - > > DTHREADSAFE=0 -DSQLITE_OMIT_LOAD_EXTENSION sqlite3.c > > sqlite3.c: In function `unixShmMap': > > sqlite3.c:26184: error: `MAP_FAILED' undeclared (first use in this > > function) > > sqlite3.c:26184: error: (Each undeclared identifier is reported only > > once > > sqlite3.c:26184: error: for each function it appears in.) > > > > After applying this patch: > > --8<--- > > --- sqlite3.c.org 2011-05-23 15:27:35 +0200 > > +++ sqlite3.c 2011-05-23 15:29:55 +0200 > > @@ -22661,6 +22661,10 @@ struct unixFile { > > */ > > #define SQLITE_WHOLE_FILE_LOCKING 0x0001 /* Use whole-file locking */ > > > > +#ifndef MAP_FAILED > > +#define MAP_FAILED ((void *) -1) > > +#endif > > + > > /* > > ** Include code that is common to all os_*.c files > > */ > > -->8--- > >
> > > make test
> > : > > All tests successful. > > Files=59, Tests=1308, 87 wallclock secs ( 4.61 usr 0.48 sys + 53.42 > > cusr 3.96 csys = 62.47 CPU) > > Result: PASS
> > >
> > > -- > H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ > using 5.00307 through 5.14 and porting perl5.15.x on HP-UX 10.20, 11.00, > 11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.4 and AIX 5.2 and 5.3. > http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ > http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/ > _______________________________________________ > sqlite-users mailing list > sqlite-users@sqlite.org > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users >
-- D. Richard Hipp drh@sqlite.org
RT-Send-CC: drh [...] sqlite.org
Download (untitled) / with headers
text/plain 3.7k
I'm really glad to hear the news. The fix will be taken in DBD::SQLite in due time. Thank you for your kind reply. -- Kenichi Ishigaki On Wed Jun 22 07:48:52 2011, drh@sqlite.org wrote: Show quoted text
> On Tue, Jun 21, 2011 at 7:29 AM, H.Merijn Brand <h.m.brand@xs4all.nl> > wrote: >
> > On Mon, 23 May 2011 18:45:14 +0200, "Bugs in DBD-SQLite via RT" > > <bug-DBD-SQLite@rt.cpan.org> wrote: > > > > > > This (rather clear) bug report neither got any acknowledgement, not > > does it appear in the RT trackers. > >
> > The problem was fixed in SQLite on 2011-04-15 with this check-in: > http://www.sqlite.org/src/ci/8775f159c1 > >
> > > > Meanwhile things got even worse. > >
> > > Using gcc-3.4.6 on HP-UX 10.20:
> > > > HP-UX 10.20 does not have pread at all. -UUSE_PREAD doesn't work > > (enough) as the test is (very) wrong. SQLITE_ENABLE_LOCKING_STYLE is > > overruled in this section when passed as
> -USQLITE_ENABLE_LOCKING_STYLE
> > > > --8<--- line 23983 > > #if !defined(SQLITE_ENABLE_LOCKING_STYLE) > > # if defined(__APPLE__) > > # define SQLITE_ENABLE_LOCKING_STYLE 1 > > # else > > # define SQLITE_ENABLE_LOCKING_STYLE 0 > > # endif > > #endif > > -->8--- > > > > And thus leaving > > --8<--- line 24453 > > #if defined(USE_PREAD) || defined(SQLITE_ENABLE_LOCKING_STYLE) > > { "pread", (sqlite3_syscall_ptr)pread, 0 }, > > #else > > { "pread", (sqlite3_syscall_ptr)0, 0 }, > > #endif > > -->8--- > > > > a useless and bogus test. > > > > That second test (also for pwrite) should either test for the
> *content*
> > of SQLITE_ENABLE_LOCKING_STYLE or not test on it at all > >
> > > > make test
> > > gcc -c -I. -I/opt/perl/lib/site_perl/5.14.0/PA-RISC2.0/auto/DBI
> -mpa-
> > > risc-1-1 -DPERL_DONT_CREATE_GVSV -D_HPUX_SOURCE
> -fno-strict-aliasing -
> > > pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION= > > > \"1.31\" -DXS_VERSION=\"1.31\" -fPIC "-I/opt/perl/lib/5.14.0/PA-
> RISC2.0/
> > > CORE" -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS - > > > DSQLITE_ENABLE_COLUMN_METADATA -DNDEBUG=1 -DHAVE_USLEEP=1 - > > > DTHREADSAFE=0 -DSQLITE_OMIT_LOAD_EXTENSION sqlite3.c > > > sqlite3.c: In function `unixShmMap': > > > sqlite3.c:26184: error: `MAP_FAILED' undeclared (first use in this > > > function) > > > sqlite3.c:26184: error: (Each undeclared identifier is reported
> only
> > > once > > > sqlite3.c:26184: error: for each function it appears in.) > > > > > > After applying this patch: > > > --8<--- > > > --- sqlite3.c.org 2011-05-23 15:27:35 +0200 > > > +++ sqlite3.c 2011-05-23 15:29:55 +0200 > > > @@ -22661,6 +22661,10 @@ struct unixFile { > > > */ > > > #define SQLITE_WHOLE_FILE_LOCKING 0x0001 /* Use whole-file
> locking */
> > > > > > +#ifndef MAP_FAILED > > > +#define MAP_FAILED ((void *) -1) > > > +#endif > > > + > > > /* > > > ** Include code that is common to all os_*.c files > > > */ > > > -->8--- > > >
> > > > make test
> > > : > > > All tests successful. > > > Files=59, Tests=1308, 87 wallclock secs ( 4.61 usr 0.48 sys +
> 53.42
> > > cusr 3.96 csys = 62.47 CPU) > > > Result: PASS
> > > >
> > > > > > -- > > H.Merijn Brand http://tux.nl Perl Monger
> http://amsterdam.pm.org/
> > using 5.00307 through 5.14 and porting perl5.15.x on HP-UX 10.20,
> 11.00,
> > 11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.4 and AIX 5.2 and
> 5.3. > smoke.org/ > disclaimers/
> > _______________________________________________ > > sqlite-users mailing list > > sqlite-users@sqlite.org > > http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users > >
> > >
I believe this has been fixed for some time. If not, please reopen this. Thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.