Skip Menu |
 

This queue is for tickets about the PAR-Packer CPAN distribution.

Report information
The Basics
Id: 68916
Status: resolved
Priority: 0/
Queue: PAR-Packer

People
Owner: RSCHUPP [...] cpan.org
Requestors: nohuhu [...] nohuhu.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Solaris with Sun Workshop: heavy cosmetic issue
Date: Sat, 18 Jun 2011 21:48:49 +0400
To: <bug-PAR-Packer [...] rt.cpan.org>
From: Alexander Tokarev <nohuhu [...] nohuhu.org>
Hi PAR::Packer maintainers, I was trying to build PAR::Packer 1.009 with Sun Workshop C Compiler ­ I believe it's version 12 ­ and encountered a bug that is, while being purely cosmetic, is nevertheless seriously annoying. The culprit is C code generated by myldr/file2c.pl on line 76: print $out "const char ${c_var}${suffix}[] = "; The resulting C code produces warnings like this: "my_libperl.c", line 8: warning: initializer does not fit or is out of range: 155 The problem is that C compiler warns literally on every line of the compiled my_libperl.c and my_par.c. Considering that I'm working remotely on a slow system, and my_libperl.c and my_par.c combined total to 38 mb of code, you can see why I didn't have the patience to wait till it buildsŠ The fix is really easy: either change "const char" to "const unsigned char" or add "-w" parameter to cc command line. I did that and PAR::Packer finished building in like five minutes instead of previously unfinished three hours. Hope you will approve this patch, it may save lots of frustration to fellow Solaris users. Regards, Alex.
Download (untitled) / with headers
text/plain 260b
On 2011-06-18 13:49:02, nohuhu@nohuhu.org wrote: Show quoted text
> print $out "const char ${c_var}${suffix}[] = ";
Thanks for reporting, your concerns will be addressed in the next release of PAR::Packer (all generated byte arrays will use "unsigned char"). Cheers, Roderich
Subject: Re: [rt.cpan.org #68916] Solaris with Sun Workshop: heavy cosmetic issue
Date: Tue, 28 Jun 2011 15:14:17 +0400
To: <bug-PAR-Packer [...] rt.cpan.org>
From: Alexander Tokarev <nohuhu [...] nohuhu.org>
Download (untitled) / with headers
text/plain 574b
The same line is causing trouble again when building with Perl 5.6: it chokes on "${suffix}[]". Changing it to "${suffix}"."[]" does the trick. Regards, Alex. On 6/25/11 7:40 PM, "Roderich Schupp via RT" <bug-PAR-Packer@rt.cpan.org> wrote: Show quoted text
><URL: https://rt.cpan.org/Ticket/Display.html?id=68916 > > >On 2011-06-18 13:49:02, nohuhu@nohuhu.org wrote:
>> print $out "const char ${c_var}${suffix}[] = ";
> >Thanks for reporting, your concerns will be addressed >in the next release of PAR::Packer (all generated byte arrays >will use "unsigned char"). > >Cheers, Roderich
Download (untitled) / with headers
text/plain 261b
On 2011-06-28 13:53:39, nohuhu@nohuhu.org wrote: Show quoted text
> The same line is causing trouble again when building with Perl 5.6: it > chokes on "${suffix}[]". Changing it to "${suffix}"."[]" does the trick.
Known bug in Perl 5.6 - simply don't use that stoneage version.
Fixed in PAR::Packer 1.010


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.