Skip Menu |
 

This queue is for tickets about the MIME-tools CPAN distribution.

Report information
The Basics
Id: 68879
Status: resolved
Priority: 0/
Queue: MIME-tools

People
Owner: dfs+pause [...] roaringpenguin.com
Requestors: drummike [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 5.502
Fixed in: (no value)



Subject: Smtpsend.t test failure - patch
Download (untitled) / with headers
text/plain 816b
make test reported failure of Smtpsend.t t/Smtpsend.t ...................... accept failed: Connection timed out at t/Smtpsend.t line 46. # Looks like your test exited with 110 before it could output anything. t/Smtpsend.t ...................... Dubious, test returned 110 (wstat 28160, 0x6e00) Failed 9/9 subtests Added: sleep 1; just before accept and test passes @@ -39,6 +39,8 @@ if (!$pid) { exit(0); } +sleep 1; + # In the parent my $s = $sock->accept(); t/Smtpsend.t ...................... ok This problem accounts for some of the CPAN testers failures. [mike@watson t]$ perl -v This is perl 5, version 14, subversion 0 (v5.14.0) built for i686-linux [mike@watson t]$ uname -a Linux watson.localdomain 2.6.35.13-92.fc14.i686.PAE #1 SMP Sat May 21 17:33:09 UTC 2011 i686 i686 i386 GNU/Linux
Subject: MIME-tools-t-Smtpsend.patch
diff --git a/Smtpsend.t b/Smtpsend.t index 4c6f689..44e73b1 100644 --- a/Smtpsend.t +++ b/Smtpsend.t @@ -39,6 +39,8 @@ if (!$pid) { exit(0); } +sleep 1; + # In the parent my $s = $sock->accept(); if (!$s) {
Subject: Re: [rt.cpan.org #68879] Smtpsend.t test failure - patch
Date: Thu, 20 Oct 2011 14:01:27 -0400
To: bug-MIME-tools [...] rt.cpan.org
From: "David F. Skoll" <dfs [...] roaringpenguin.com>
Download (untitled) / with headers
text/plain 755b
Hi, Show quoted text
> make test reported failure of Smtpsend.t
Thanks for your patch. I prefer my version, below. Regards, David. diff --git a/t/Smtpsend.t b/t/Smtpsend.t index 4c6f689..88c8997 100644 --- a/t/Smtpsend.t +++ b/t/Smtpsend.t @@ -34,6 +34,7 @@ if (!defined($pid)) { if (!$pid) { # In the child + sleep(1); $top->smtpsend(Host => '127.0.0.1', Port => 5225); exit(0); @@ -42,8 +43,12 @@ if (!$pid) { # In the parent my $s = $sock->accept(); if (!$s) { - kill(9, $pid); - die("accept failed: $!"); + sleep(1); + $s = $sock->accept(); + if (!$s) { + kill(9, $pid); + die("accept failed: $!"); + } } $s->print("220 Go ahead\n");
Download (untitled) / with headers
text/plain 984b
On Thu Oct 20 14:01:38 2011, dfs@roaringpenguin.com wrote: Show quoted text
> Hi, >
> > make test reported failure of Smtpsend.t
> > Thanks for your patch. I prefer my version, below. > > Regards, > > David. > > diff --git a/t/Smtpsend.t b/t/Smtpsend.t > index 4c6f689..88c8997 100644 > --- a/t/Smtpsend.t > +++ b/t/Smtpsend.t > @@ -34,6 +34,7 @@ if (!defined($pid)) { > > if (!$pid) { > # In the child > + sleep(1); > $top->smtpsend(Host => '127.0.0.1', > Port => 5225); > exit(0); > @@ -42,8 +43,12 @@ if (!$pid) { > # In the parent > my $s = $sock->accept(); > if (!$s) { > - kill(9, $pid); > - die("accept failed: $!"); > + sleep(1); > + $s = $sock->accept(); > + if (!$s) { > + kill(9, $pid); > + die("accept failed: $!"); > + } > } > > $s->print("220 Go ahead\n");
I’ve just run into the same problem. Is there a chance you could make another release soon?
RT-Send-CC: dfs [...] roaringpenguin.com
+1 on applying the patch
RT-Send-CC: dfs [...] roaringpenguin.com
+1 on applying the patch
Download (untitled) / with headers
text/plain 108b
Hi, I have just uploaded MIME-tools-5.503 to CPAN, which I believe resolves this ticket. Regards, David.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.