Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DB_File CPAN distribution.

Report information
The Basics
Id:
68287
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
TODDR [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
1.822
Fixed in:
1.829

Attachments


Subject: Makefile.PL prevents INSTALLDIRS on command line.
I noticed today that Makefile.PL for DB_File does not honor INSTALLDIRS being passed to it from command line. I believe this is because you're putting it inside a MACRO section. Since 5.11, the correct INSTALLDIRS for a cpan sourced module is site. It's my understanding Dual Lived modules are not supposed to overwrite what was installed with core. I've attached a patch to make the defaults more in line with perl's need over it's history.
Subject: DB_File_INSTALLDIRS.patch.txt
commit 95115572e8e7941b8db887f5eceb0a18a4d10fa9 Author: Todd Rinaldo <toddr@cpanel.net> Date: Wed May 18 09:18:04 2011 -0500 Remove INSTALLDIRS from macro in Makefile.PL so site override works diff --git a/Makefile.PL b/Makefile.PL index a586a04..c05b552 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -60,13 +60,12 @@ WriteMakefile( AUTHOR => 'Paul Marquess <pmqs@cpan.org>') : () ), - - + ($] < 5.008 || $] > 5.011) ? (INSTALLDIRS => 'site') : ( INSTALLDIRS => 'perl' ), #OPTIMIZE => '-g', 'depend' => { 'Makefile' => 'config.in', 'version$(OBJ_EXT)' => 'version.c'}, 'clean' => { FILES => 'constants.h constants.xs' }, - 'macro' => { INSTALLDIRS => 'perl', my_files => "@files" }, + 'macro' => { my_files => "@files" }, 'dist' => { COMPRESS => 'gzip', SUFFIX => 'gz', DIST_DEFAULT => 'MyDoubleCheck tardist'}, );


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.