Skip Menu |
 

This queue is for tickets about the Curses-UI CPAN distribution.

Report information
The Basics
Id: 68127
Status: open
Priority: 0/
Queue: Curses-UI

People
Owner: Nobody in particular
Requestors: user42 [...] zip.com.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: perl 5.12 vs prototypes (@;)
Date: Thu, 12 May 2011 11:10:37 +1000
To: bug-Curses-UI [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
Download (untitled) / with headers
text/plain 531b
Perl 5.12 seems to complain that prototypes like sub add($@;) in Curses::UI::Container have stuff after the "@". I suppose the ";" is harmless there and ought to be ignored, but removing it might avoid warnings. I thought actually that prototypes have no effect on methods as such anyway ... -- The sigfile subcultures series: Cairns Goths. Did you know Cairns has a thriving Goth scene? It takes dedication to dress in long black overcoats in 95% humidity and maintain a pasty complexion under a fierce tropical sun.
Subject: [patch] perl 5.12 vs prototypes (@;)
Attached is a trivial patch.
Subject: prototypes.patch
Download prototypes.patch
text/x-diff 1.7k
Description: drop the trailing semicolon after '@' in function prototypes they are useless and perl 5.12 emits warnings about them Author: Damyan Ivanov <dmn@debian.org> Bug: https://rt.cpan.org/Ticket/Display.html?id=68127 Bug-Debian: http://bugs.debian.org/628128 Forwarded: yes --- a/lib/Curses/UI/Container.pm +++ b/lib/Curses/UI/Container.pm @@ -64,7 +64,7 @@ DESTROY() } # Add an object to the container -sub add($@;) +sub add($@) { my $this = shift; my $id = shift; @@ -472,7 +472,7 @@ sub event_onblur() } -sub set_focusorder(@;) +sub set_focusorder(@) { my $this = shift; my @order = @_; @@ -480,7 +480,7 @@ sub set_focusorder(@;) return $this; } -sub set_draworder(@;) +sub set_draworder(@) { my $this = shift; my @order = @_; --- a/lib/Curses/UI/Widget.pm +++ b/lib/Curses/UI/Widget.pm @@ -353,7 +353,7 @@ sub process_padding($;) } } -sub width_by_windowscrwidth($@;) +sub width_by_windowscrwidth($@) { my $width = shift || 0; $width = shift if ref $width; # make $this->width... possible. @@ -377,7 +377,7 @@ sub width_by_windowscrwidth($@;) return $width; } -sub height_by_windowscrheight($@;) +sub height_by_windowscrheight($@) { my $height = shift || 0; $height = shift if ref $height; # make $this->height... possible. @@ -895,7 +895,7 @@ sub set_routine($$;) return $this; } -sub set_binding($@;) +sub set_binding($@) { my $this = shift; my $routine = shift; @@ -921,7 +921,7 @@ sub set_binding($@;) return $this; } -sub set_mouse_binding($@;) +sub set_mouse_binding($@) { my $this = shift; my $routine = shift; --- a/lib/Curses/UI/Listbox.pm +++ b/lib/Curses/UI/Listbox.pm @@ -218,7 +218,7 @@ sub add_labels(;$) } -sub maxlabelwidth(@;) +sub maxlabelwidth(@) { my %args = @_;
Fixed in .9608


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.