Skip Menu |
 

This queue is for tickets about the Sysadm-Install CPAN distribution.

Report information
The Basics
Id: 68095
Status: open
Priority: 0/
Queue: Sysadm-Install

People
Owner: Nobody in particular
Requestors: kai.von.thadden [...] hp.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Sysadm-Install-0.36 tap with {raise_error => 1} doesn't work correctly
Date: Tue, 10 May 2011 20:35:22 +0000
To: "bug-Sysadm-Install [...] rt.cpan.org" <bug-Sysadm-Install [...] rt.cpan.org>
From: "Thadden, Kai von" <kai.von.thadden [...] hp.com>
Download (untitled) / with headers
text/plain 721b
Module version is: Sysadm-Install-0.36 Sample: #!/opt/perl_64/bin/perl use warnings; use strict; use Carp; use Getopt::Long; use Log::Log4perl qw(:easy); use Sysadm::Install qw(:all); tap({raise_error => 1}, "ls"); returns tap 'ls' 2>/tmp/JyeDMqFoaQ.dat | | failed (No such file or directory) at ./minitest.pl line 14 source code shows that it is easy to fix my $exit_code = $?; if($opts->{raise_error}) { LOGCROAK("tap $cmd | failed ($!)"); } Proposed fix my $exit_code = $?; if( $exit_code != 0 && $opts->{raise_error}) { LOGCROAK("tap $cmd | failed ($!)"); } Best regards and thank you for this very useful module Kai
Download smime.p7s
application/x-pkcs7-signature 4.8k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #68095] Sysadm-Install-0.36 tap with {raise_error => 1} doesn't work correctly
Date: Tue, 17 May 2011 18:16:30 -0700 (PDT)
To: "Thadden, Kai von via RT" <bug-Sysadm-Install [...] rt.cpan.org>
From: Mike Schilli <m [...] perlmeister.com>
Download (untitled) / with headers
text/plain 341b
On Tue, 10 May 2011, Thadden, Kai von via RT wrote: Show quoted text
> Proposed fix my $exit_code = $?; if( $exit_code != 0 && > $opts->{raise_error}) { LOGCROAK("tap $cmd | failed ($!)"); }
Applied with test case, thanks for your contribution. https://github.com/mschilli/sysadm-install-perl/commit/398dc9c3193c62971c6ec5214f9ead41d7a46bbd -- Mike


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.