Skip Menu |
 

This queue is for tickets about the Catalyst-Plugin-I18N-PathPrefix CPAN distribution.

Report information
The Basics
Id: 67926
Status: resolved
Priority: 0/
Queue: Catalyst-Plugin-I18N-PathPrefix

People
Owner: Nobody in particular
Requestors: bricas [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.03
Fixed in: (no value)



Subject: Plugin obliterates query params in $c->req->uri
Download (untitled) / with headers
text/plain 388b
It seems that this plugin obliterates any query params in $c->req->uri. I found this out when try to write some paging code which used $c->req->uri_with(). I would hazard a guess that line 261 is the culprit: $c->req->uri(URI->new($c->req->base . $c->req->path)); $c->req->params stays in tact so I've simple re-used that by doing: $c->req->uri->query_form( $c->req->params );
Download (untitled) / with headers
text/plain 200b
As is turns out my use of params was having some unwanted side-effects (i.e. handling POST improperly) -- so, the more appropriate fix would be: $c->req->uri->query_form( $c->req->query_params );
From: MENDEL [...] cpan.org
Download (untitled) / with headers
text/plain 505b
On Tue May 03 18:42:22 2011, BRICAS wrote: Show quoted text
> It seems that this plugin obliterates any query params in $c->req->uri. > I found this out when try to write some paging code which used > $c->req->uri_with().
I just realized that I forgot to release the module after the cleanup/refactoring/optimization rounds that I did in last autumn.. which is a pity, as those also fixed this bug (by accident, if one can call hours of code cleanup an accident;-). Now added a test for this bug and uploaded 0.04. norbi


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.