Skip Menu |
 

This queue is for tickets about the Cache-Cache CPAN distribution.

Report information
The Basics
Id: 67717
Status: rejected
Priority: 0/
Queue: Cache-Cache

People
Owner: Nobody in particular
Requestors: carnil [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Use Digest::SHA instead of Digest::SHA1
Date: Sat, 23 Apr 2011 21:16:06 +0200
To: bug-Cache-Cache [...] rt.cpan.org
From: Salvatore Bonaccorso <carnil [...] debian.org>
Download (untitled) / with headers
text/plain 284b
Hi Attached patch changes the module to use Digest::SHA instead of Digest::SHA1. igest::SHA is part of the standard perl distribution since perl v5.9.3 so this reduces the number of external dependencies by one. Please consider applying it for the next release. Regards, Salvatore

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #67717] [PATCH] Use Digest::SHA instead of Digest::SHA1
Date: Sat, 23 Apr 2011 17:09:16 -0700
To: bug-Cache-Cache [...] rt.cpan.org
From: Jonathan Swartz <swartz [...] pobox.com>
Download (untitled) / with headers
text/plain 2.2k
Hi Salvatore, Cache::Cache isn't really maintained anymore. Have you looked at its successor, CHI? Of course that may have too many dependencies for you, too. :) Best Jon On Apr 23, 2011, at 12:16 PM, Salvatore Bonaccorso via RT wrote: Show quoted text
> Sat Apr 23 15:16:17 2011: Request 67717 was acted upon. > Transaction: Ticket created by carnil@debian.org > Queue: Cache-Cache > Subject: [PATCH] Use Digest::SHA instead of Digest::SHA1 > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: carnil@debian.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=67717 > > > > Hi > > Attached patch changes the module to use Digest::SHA instead of > Digest::SHA1. igest::SHA is part of the standard perl distribution since > perl v5.9.3 so this reduces the number of external dependencies by one. > > Please consider applying it for the next release. > > Regards, > Salvatore > > Index: lib/Cache/FileBackend.pm > =================================================================== > --- lib/Cache/FileBackend.pm (revision 73321) > +++ lib/Cache/FileBackend.pm (working copy) > @@ -12,7 +12,7 @@ > > use strict; > use Cache::CacheUtils qw( Assert_Defined Build_Path Freeze_Data Thaw_Data ); > -use Digest::SHA1 qw( sha1_hex ); > +use Digest::SHA qw( sha1_hex ); > use Error; > use File::Path qw( mkpath ); > use File::Temp qw( tempfile ); > Index: META.yml > =================================================================== > --- META.yml (revision 73321) > +++ META.yml (working copy) > @@ -5,7 +5,6 @@ > version_from: lib/Cache/Cache.pm > installdirs: site > requires: > - Digest::SHA1: 2.02 > Error: 0.15 > File::Spec: 0.82 > Storable: 1.014 > Index: Makefile.PL > =================================================================== > --- Makefile.PL (revision 73321) > +++ Makefile.PL (working copy) > @@ -10,7 +10,6 @@ > my $COMPRESS = 'gzip'; > my $SUFFIX = '.gz'; > my $DEFAULT_PREREQ_PM = { > - Digest::SHA1 => '2.02', > File::Spec => '0.82', > Storable => '1.014', > IPC::ShareLite => '0.09', > <signature.asc>
Subject: Re: [rt.cpan.org #67717] [PATCH] Use Digest::SHA instead of Digest::SHA1
Date: Sun, 24 Apr 2011 09:51:50 +0200
To: Jonathan Swartz via RT <bug-Cache-Cache [...] rt.cpan.org>
From: Salvatore Bonaccorso <carnil [...] debian.org>
Download (untitled) / with headers
text/plain 972b
Hi Jonathan On Sat, Apr 23, 2011 at 08:12:35PM -0400, Jonathan Swartz via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=67717 > > > Hi Salvatore, > > Cache::Cache isn't really maintained anymore. Have you looked at its > successor, CHI? Of course that may have too many dependencies for > you, too. :)
Thank you for your fast reply :-) Indeed we have already too CHI in Debian [1]. Thanks for developing this. The reason you got my request (I did not check first if Cache-Cache has a successor, sorry), was that we have the 'goal' to drop the libdigest-sha1-perl package (which packages Digest::SHA1) so submitting reports for that, as Digest::SHA provides the same functionality. See [2] for more details. [1] http://packages.debian.org/libchi-perl [2] http://bugs.debian.org/594273 So at some point, if libchi-perl replaces libcache-cache-perl, we may remove that package too, thanks for the pointer. So, thanks again, and best regards Salvatore
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.