Skip Menu |
 

This queue is for tickets about the Test-Unit CPAN distribution.

Report information
The Basics
Id: 6758
Status: open
Priority: 0/
Queue: Test-Unit

People
Owner: mca1001 [...] users.sourceforge.net
Requestors: aa29 [...] mail.ru
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Constructing debug message in Test::Unit::Assertion::CodeRef takes too mach time
Download (untitled) / with headers
text/plain 146b
debug(" asserting [$self]"...) takes to mach time to construct parameter string and if debbuging is not enabled this message is totally in vain.
Download (untitled) / with headers
text/plain 357b
[guest - Fri Jun 25 10:17:00 2004]: Show quoted text
> debug(" asserting [$self]"...) takes to mach time to construct > parameter string and if debbuging is not enabled this message is > totally in vain.
Of course: when the object is a message, stringification will fill-in the whole message. So, you probably can better do debug(" asserting [".$self->subject."]");
Download (untitled) / with headers
text/plain 1.1k
On Fri Jun 25 10:17:00 2004, guest wrote: Show quoted text
> debug(" asserting [$self]"...) takes to mach time to construct > parameter string and if debbuging is not enabled this message is > totally in vain.
Hi aa29@, Thank you for the report and I'm sorry it has taken a long time to act on it. I have fixed this in http://perlunit.git.sourceforge.net/git/gitweb.cgi?p=perlunit/perlunit;a=commit;h=0af160c2ac42c3da16e6733b1da8f4772959b40c which I will release shortly. The speedup for a set of tests like the distribution self-tests is about 50% of the CPU time. On Tue Sep 21 05:42:40 2004, MARKOV wrote: Show quoted text
> Of course: when the object is a message, stringification will > fill-in the whole message. So, you probably can better do > > debug(" asserting [".$self->subject."]");
Hi MARKOV, The debug output is rather noisy anyway, but it's mostly for internal use. The magical to_string methods will still be slow, but are no longer called internally. I wasn't sure what you wanted to change by using a ->subject method instead of the existing (implicit) ->to_string so I didn't use that idea. Will mark the ticket resolved, but please reply if you are still interested in some related change. Thanks, -- Matthew
Subject: Re: [rt.cpan.org #6758] Resolved: Constructing debug message in Test::Unit::Assertion::CodeRef takes too mach time
Date: Tue, 28 Jun 2011 13:06:55 +0400
To: bug-Test-Unit [...] rt.cpan.org
From: Andrey Alakozov <aa29 [...] mail.ru>
Thanks! -- Andrey


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.