Skip Menu |
 

This queue is for tickets about the Net-EPP CPAN distribution.

Maintainer(s)' notes

Please don't use rt.cpan.org to submit bug reports! Please email any bug reports to epp@centralnic.com instead. Thanks.

Report information
The Basics
Id: 67327
Status: resolved
Priority: 0/
Queue: Net-EPP

People
Owner: Nobody in particular
Requestors: ilyuha1 [...] mail.ru
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.16
Fixed in: (no value)



Subject: Warning under perl-5.12
Download (untitled) / with headers
text/plain 414b
$ perl -MNet::EPP::Simple -we '' UNIVERSAL->import is deprecated and will be removed in a future perl at /home/ichesnokov/perl5/lib/perl5/Net/EPP/Simple.pm line 12 UNIVERSAL->import is deprecated and will be removed in a future perl at /home/ichesnokov/perl5/lib/perl5/Net/EPP/Client.pm line 13 The solution is to remove 'use UNIVERSAL qw(isa);' from modules and use absolute function name. Patch is attached.
Subject: net-epp-universal.diff
Index: lib/Net/EPP/Simple.pm =================================================================== --- lib/Net/EPP/Simple.pm (revision 82) +++ lib/Net/EPP/Simple.pm (working copy) @@ -9,7 +9,6 @@ use Net::EPP::Frame; use Net::EPP::ResponseCodes; use Time::HiRes qw(time); -use UNIVERSAL qw(isa); use base qw(Net::EPP::Client); use constant EPP_XMLNS => 'urn:ietf:params:xml:ns:epp-1.0'; use vars qw($Error $Code $Message); @@ -1272,7 +1271,7 @@ my $hello = Net::EPP::Frame::Hello->new; my $response = $self->request($hello); - return (isa($response, 'XML::LibXML::Document') ? 1 : undef); + return (UNIVERSAL::isa($response, 'XML::LibXML::Document') ? 1 : undef); } sub _request { @@ -1329,10 +1328,10 @@ $Error = ''; $Message = ''; - $frame->clTRID->appendText(sha1_hex(ref($self).time().$$)) if (isa($frame, 'Net::EPP::Frame::Command')); + $frame->clTRID->appendText(sha1_hex(ref($self).time().$$)) if (UNIVERSAL::isa($frame, 'Net::EPP::Frame::Command')); $self->debug(sprintf('sending a %s to the server', ref($frame))); - if (isa($frame, 'XML::LibXML::Document')) { + if (UNIVERSAL::isa($frame, 'XML::LibXML::Document')) { map { $self->debug('C: '.$_) } split(/\n/, $frame->toString(1)); } else { @@ -1342,7 +1341,7 @@ my $response = $self->SUPER::request($frame); - map { $self->debug('S: '.$_) } split(/\n/, $response->toString(1)) if (isa($response, 'XML::LibXML::Document')); + map { $self->debug('S: '.$_) } split(/\n/, $response->toString(1)) if (UNIVERSAL::isa($response, 'XML::LibXML::Document')); return $response; } Index: lib/Net/EPP/Client.pm =================================================================== --- lib/Net/EPP/Client.pm (revision 82) +++ lib/Net/EPP/Client.pm (working copy) @@ -10,7 +10,6 @@ use IO::Socket; use IO::Socket::SSL; use vars qw($XMLDOM $EPPFRAME); -use UNIVERSAL qw(isa); use strict; use warnings;
Patch applied and committed to SVN.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.