Skip Menu |
 

This queue is for tickets about the Devel-CheckLib CPAN distribution.

Report information
The Basics
Id: 67300
Status: resolved
Priority: 0/
Queue: Devel-CheckLib

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: [PATCH] space in pwd
Download (untitled) / with headers
text/plain 107b
Attached patch fixes issues when the current directory contains a space. Windows "My Documents" typically.
Subject: Devel-CheckLib-spacepath.patch
diffbk Devel-CheckLib-0.92 diff -u Devel-CheckLib-0.92/lib/Devel/CheckLib.pm~ Devel-CheckLib-0.92/lib/Devel/CheckLib.pm --- Devel-CheckLib-0.92/lib/Devel/CheckLib.pm~ 2010-12-12 16:50:50.000000000 +0100 +++ Devel-CheckLib-0.92/lib/Devel/CheckLib.pm 2011-04-07 13:38:27.694118400 +0200 @@ -255,7 +255,7 @@ } warn "# @sys_cmd\n" if $args{debug}; my $rv = $args{debug} ? system(@sys_cmd) : _quiet_system(@sys_cmd); - push @missing, $header if $rv != 0 || ! -x $exefile; + push @missing, $header if $rv != 0 || ! -x $exefile; _cleanup_exe($exefile); unlink $cfile; } @@ -308,7 +308,9 @@ warn "# @sys_cmd\n" if $args{debug}; my $rv = $args{debug} ? system(@sys_cmd) : _quiet_system(@sys_cmd); push @missing, $lib if $rv != 0 || ! -x $exefile; - push @wrongresult, $lib if $rv == 0 && -x $exefile && system(File::Spec->rel2abs($exefile)) != 0; + my $absexefile = File::Spec->rel2abs($exefile); + $absexefile = '"'.$absexefile.'"' if $absexefile =~ m/\s/; + push @wrongresult, $lib if $rv == 0 && -x $exefile && system($absexefile) != 0; _cleanup_exe($exefile); } unlink $cfile;
Download (untitled) / with headers
text/plain 190b
Thanks. I included it. On 2011-4月-07 木 07:42:47, rurban@x-ray.at wrote: Show quoted text
> Attached patch fixes issues when the current directory contains a space. > Windows "My Documents" typically.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.