Skip Menu |
 

This queue is for tickets about the Date-ISO CPAN distribution.

Report information
The Basics
Id: 67
Status: resolved
Priority: 0/
Queue: Date-ISO

People
Owner: Nobody in particular
Requestors: jesse [...] fsck.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Date: Wed, 28 Nov 2001 17:14:47 -0500
From: Jesse <jesse [...] fsck.com>
To: bug-date-iso [...] rt.cpan.org
Subject: Date::ISO doesn't deal properly with offsets not being passed
Download (untitled) / with headers
text/plain 1.3k
here's a patch which fixes this, against Date::ISO 1.25. --- Date-ISO-1.25/lib/Date/ISO.pm Mon Nov 26 21:44:43 2001 +++ Date-ISO-1.25.new//lib/Date/ISO.pm Wed Nov 28 17:09:48 2001 @@ -105,7 +105,7 @@ $self = $class->SUPER::new( year => $1, month => $2, day => $3, hour => 0, - min => 0, sec => 0, offset => $args{offset} ); + min => 0, sec => 0, offset => $offset ); } # 199702 format @@ -113,7 +113,7 @@ $self = $class->SUPER::new( year => $1, month => $2, day => 1, hour => 0, min => 0, sec => 0, - offset => $args{offset} ); + offset => $offset ); } # 1997-W06-2, 1997W062,, 1997-06-2, 1997062, 1996-06, 1997W06 formats @@ -126,7 +126,7 @@ $self = $class->SUPER::new( year => $year, month => $month, day => $day, hour => 0, min => 0, sec => 0, - offset => $args{offset} ); + offset => $offset ); # Don't know what the format was } -- jesse reed vincent -- root@eruditorum.org -- jesse@fsck.com 70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90 There are no supercomputer applications that are solvable that cannot be solved in finite time using a fucking TRS-80 with approprite disk/tape drives. Zero. -Tanj
Date: Wed, 28 Nov 2001 17:55:24 -0500 (EST)
From: Rich Bowen <rbowen [...] rcbowen.com>
To: Jesse via RT <bug-Date-ISO [...] rt.cpan.org>
Subject: Re: [cpan #67] Date::ISO doesn't deal properly with offsets not being passed
Download (untitled) / with headers
text/plain 1.5k
On Wed, 28 Nov 2001, Jesse via RT wrote: Show quoted text
> > > This message about Date-ISO was sent to you by jesse@fsck.com via rt.cpan.org
Thanks, this is great. Applied. I'll release immediately, in the hopes that this, finally, will fix the problems that I am seeing, which appear to be due to ignoring the offset that my tests are passing in. Show quoted text
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=67 > > > here's a patch which fixes this, against Date::ISO 1.25. > > --- Date-ISO-1.25/lib/Date/ISO.pm Mon Nov 26 21:44:43 2001 > +++ Date-ISO-1.25.new//lib/Date/ISO.pm Wed Nov 28 17:09:48 2001 > @@ -105,7 +105,7 @@ > > $self = $class->SUPER::new( year => $1, > month => $2, day => $3, hour => 0, > - min => 0, sec => 0, offset => $args{offset} ); > + min => 0, sec => 0, offset => $offset ); > } > > # 199702 format > @@ -113,7 +113,7 @@ > > $self = $class->SUPER::new( year => $1, month => $2, > day => 1, hour => 0, min => 0, sec => 0, > - offset => $args{offset} ); > + offset => $offset ); > } > > # 1997-W06-2, 1997W062,, 1997-06-2, 1997062, 1996-06, 1997W06 formats > @@ -126,7 +126,7 @@ > > $self = $class->SUPER::new( year => $year, month => $month, > day => $day, hour => 0, min => 0, sec => 0, > - offset => $args{offset} ); > + offset => $offset ); > > # Don't know what the format was > } >
-- HTML Writers Guild training classes http://www.hwg.org/services/classes/


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.