Skip Menu |
 

This queue is for tickets about the LWP-MediaTypes CPAN distribution.

Report information
The Basics
Id: 66681
Status: resolved
Priority: 0/
Queue: LWP-MediaTypes

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 6.01
Fixed in: (no value)



Subject: Missing requires in META.yml
Download (untitled) / with headers
text/plain 339b
I think Data::Dumper and File::Basename are missing in META.yml requires section. The File::Basename is required in file_exts() that is called from public guess_media_type(). The Data::Dumper is required in a function that is never called (except a comment in a tests), but it would be good to remove the dead code or put it to META.yml.
Download (untitled) / with headers
text/plain 564b
On Thu Mar 17 04:57:17 2011, ppisar wrote: Show quoted text
> I think Data::Dumper and File::Basename are missing in META.yml requires > section. > > The File::Basename is required in file_exts() that is called from public > guess_media_type(). > > The Data::Dumper is required in a function that is never called (except > a comment in a tests), but it would be good to remove the dead code or > put it to META.yml.
Both of these modules have been shipped as part of perl itself since perl 5.0. As such there is no requirement of having them part of the dependency declarations.
Download (untitled) / with headers
text/plain 159b
I removed the _dump() function and thus the Data::Dumper reference. I agree that there should ok to assume File::Basename is available as a core perl module.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.