Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 66642
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: scop [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.70
Fixed in: (no value)



Subject: $err->column() incorrectly maxed out as 80
Download (untitled) / with headers
text/plain 627b
Looks like XML::LibXML 1.70 incorrectly limits the max column() value for errors to 80 at least for some cases. Reproducer: use XML::LibXML qw(); eval { XML::LibXML->new()->parse_string(' <foo attr1="value1" attr2="value2" attr3="value2" attr4="value2" attr5="value2" attr6="value2" attr7="value2" attr8="value2" attr9="value2" attr10="value2" attr11="value2" attr12="value2" attr13="value2"attr14="value2" attr15="value2" /> ') }; print $@->dump(); Note that the column reported is 80. It should be something like 203 instead (depending how you count the columns, but by 203 I mean the starting "a" of "attr14" above).
Download (untitled) / with headers
text/plain 189b
Fixed in the repository. The fix will be incorporated into the next CPAN release. What we did is to continue to go to the start of the line, even if it is longer than the allocated context.
Download (untitled) / with headers
text/plain 569b
On Fri Jun 17 05:46:03 2011, SHLOMIF wrote: Show quoted text
> Fixed in the repository.
Thanks. Where is the repository? Maybe you could update Makefile.PL so that the info ends up in META.yml, e.g. something like this: --- Makefile.PL~ 2011-06-14 19:56:42.000000000 +0300 +++ Makefile.PL 2011-06-17 23:54:22.141661635 +0300 @@ -45,2 +45,7 @@ 'OBJECT' => '$(O_FILES)', # add the DOM extensions to libxml2 + META_MERGE => { + resources => { + repository => "add_repo_url_here", + }, + }, );
Download (untitled) / with headers
text/plain 923b
On Fri Jun 17 16:55:10 2011, SCOP wrote: Show quoted text
> On Fri Jun 17 05:46:03 2011, SHLOMIF wrote:
> > Fixed in the repository.
> > Thanks. Where is the repository? Maybe you could update Makefile.PL so > that the info ends up in META.yml, e.g. something like this: >
The repository is on: https://bitbucket.org/shlomif/perl-xml-libxml/overview And there's already a line like that in the Makefile.PL in the repository copy there. I should note that replying to this bug re-opens the ticket, so please don't do that. Regards, -- Shlomi Fish Show quoted text
> --- Makefile.PL~ 2011-06-14 19:56:42.000000000 +0300 > +++ Makefile.PL 2011-06-17 23:54:22.141661635 +0300 > @@ -45,2 +45,7 @@ > 'OBJECT' => '$(O_FILES)', # add the DOM extensions to libxml2 > + META_MERGE => { > + resources => { > + repository => "add_repo_url_here", > + }, > + }, > );


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.