Skip Menu |
 

This queue is for tickets about the Sys-Filesystem CPAN distribution.

Report information
The Basics
Id: 66610
Status: stalled
Priority: 0/
Queue: Sys-Filesystem

People
Owner: Nobody in particular
Requestors: perl [...] galumph.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [Patch] Handle mount points containing whitespace.
Date: Mon, 14 Mar 2011 18:41:34 -0500
To: bug-Sys-Filesystem [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Download (untitled) / with headers
text/plain 810b
I've got mount points containing whitespace. On Linux, this means that /proc/self/mounts ends up containing things like "/foo/bar\040baz". Attached is a patch that deals with C-style escapes in mount points. It uses a string-eval to deal with this; not the nicest thing in the world, but there doesn't seem to be any module that does it and Perl::Critic gets away with it. :] The patch is in two forms: one complete one that does everything or three that do the change piecewise. Partial patch 1 changes Sys::Filesystem::Unix to use a $mount_point variable everywhere instead of "$vals[ $pridx->[1] ]". Partial patch 2 adds a cleanUpMountPoint() method to Sys::Filesystem::Unix and uses that to deal with the C-style escapes. Partial patch 3 changes Sys::Filesystem::Linux to use cleanUpMountPoint().

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 400b
I accept the issue - even when I do not rate it higher than wish list. Someone creating mount points containing white spaces is asking for trouble. I reject your patches - did you run tests with them o.O Some rules if you plan to rework them: 1) do not break other OS by fixing one 2) do not introduce global variables unless necessary 3) run "build test" before submitting them Best regards, Jens
Subject: Re: [rt.cpan.org #66610] [Patch] Handle mount points containing whitespace.
Date: Tue, 15 Mar 2011 06:38:02 -0500
To: bug-Sys-Filesystem [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Download (untitled) / with headers
text/plain 724b
On 3/15/11 1:24 AM, Jens Rehsack via RT wrote: Show quoted text
> I reject your patches - did you run tests with them o.O
Yes, I did. What failed for you? Show quoted text
> Someone creating mount points containing white spaces is asking for trouble.
In the example in the POD, that's the path that Ubuntu creates when you hook up an iPod. At work, I've got to deal with Samba mounts of shares containing whitespace. Show quoted text
> Some rules if you plan to rework them: > 1) do not break other OS by fixing one
If I did, I did not intend to. Show quoted text
> 2) do not introduce global variables unless necessary
What global variable? Show quoted text
> 3) run "build test" before submitting them
The plain v1.30 tests fail for me and pass with my changes. Thank you for considering this.
Download (untitled) / with headers
text/plain 137b
Please redo the patches - including tests and do a pull-request. Please do the fixes in the manner I asked you (I hope kindly enough ^^).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.