Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the Image-PNG-Rewriter CPAN distribution.

Report information
The Basics
Id: 66575
Status: resolved
Priority: 0/
Queue: Image-PNG-Rewriter

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.8
Fixed in: (no value)



Subject: Fails if GD is not available
Download (untitled) / with headers
text/plain 407b
The test t/02gd.t has the best intention to skip all tests when GD is not available. But then it has a use GD 'GD_CMP_IMAGE'; on line 35 which causes the test to fail at compile time, i.e. before the eval "use GD" is executed. This would work (tested): 35 GD->import('GD_CMP_IMAGE'); 36 my $gd2 = GD::Image->newFromPngData($re_png, 1); 37 ok(!($gd->compare($gd2) & GD::GD_CMP_IMAGE())); HTH,
Subject: Re: [rt.cpan.org #66575] Fails if GD is not available
Date: Sat, 12 Mar 2011 21:04:06 +0100
To: bug-Image-PNG-Rewriter [...] rt.cpan.org
From: Bjoern Hoehrmann <derhoermi [...] gmx.net>
Download (untitled) / with headers
text/plain 900b
* Andreas Koenig via RT wrote: Show quoted text
>The test t/02gd.t has the best intention to skip all tests when GD is >not available. But then it has a > > use GD 'GD_CMP_IMAGE'; > >on line 35 which causes the test to fail at compile time, i.e. before >the eval "use GD" is executed. > >This would work (tested): > > 35 GD->import('GD_CMP_IMAGE'); > 36 my $gd2 = GD::Image->newFromPngData($re_png, 1); > 37 ok(!($gd->compare($gd2) & GD::GD_CMP_IMAGE()));
Yeah, I thought `GD::GD_CMP_IMAGE` would work after the initial `use` but it did not so I put in the other use, thought I tested this works, but apparently I failed. I've uploaded a new version with your fix. Thank you, -- Björn Höhrmann · mailto:bjoern@hoehrmann.de · http://bjoern.hoehrmann.de Am Badedeich 7 · Telefon: +49(0)160/4415681 · http://www.bjoernsworld.de 25899 Dagebüll · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.