Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 6645
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: tom [...] jerakeen.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.25
Fixed in: (no value)



Subject: recursive_test_files runs dotfiles as tests
Download (untitled) / with headers
text/plain 796b
the regexp used to find tests if 'recursive_test_files' is on is too permissive - the '*.t' glob (used when not finding tests recursively) won't match dotfiles, and the regexp does. Specific problem case - I develop code hosted on a samba server using a mac - the mac creates ._test.t files to hold metadata, and I don't want these run as tests. --- lib/Module/Build/Base.pm.orig Wed Jun 16 17:40:01 2004 +++ lib/Module/Build/Base.pm Wed Jun 16 17:40:24 2004 @@ -1061,7 +1061,7 @@ sub expand_test_dir { my ($self, $dir) = @_; - return sort @{$self->rscan_dir($dir, qr{\.t$})} if $self->{properties}{recursive_test_files}; + return sort @{$self->rscan_dir($dir, qr{^[^\.].*\.t$})} if $self->{properties}{recursive_test_files}; return sort glob File::Spec->catfile($dir, "*.t"); }
Thanks, I'll apply this to the CVS repository, it'll be out in the next version. -Ken


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.