Skip Menu |
 

This queue is for tickets about the activitymail CPAN distribution.

Report information
The Basics
Id: 6632
Status: resolved
Priority: 0/
Queue: activitymail

People
Owner: dwheeler [...] cpan.org
Requestors: jamesb-cpan [...] comcast.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.22



Subject: Diffs aren't formatted in a <pre> tag in HTML mode
Download (untitled) / with headers
text/plain 761b
Example: ********************************* ... [snip] ... </ul> </body> </html> Revision Data ------------- Index: XXX.pm =================================================================== RCS file: /cvsroot/XXX.pm,v retrieving revision 1.14 retrieving revision 1.15 ... [snip] ... ********************************************************** The diffs occur after the closing </html> tag, which probably isn't valid HTML. Moreover, for my mail reader (Outlook 2k with ie5 -- admittedly it's not great, but it's what we're stuck with) the diff is still treated as regular HTML, and it's mashed together into one paragraph. As a temporary fix I added an opening <pre> tag at the end of the footer, which is a hack but at least makes the diff readable.
From: jamesb-cpan [...] comcast.net
Download (untitled) / with headers
text/plain 103b
I'd also like to add that "<" and ">" aren't converted into "&lt;" and "&gt;" in the diff in HTML mode.
From: jamesb-cpan [...] comcast.net
Download (untitled) / with headers
text/plain 377b
[guest - Thu Jun 17 21:05:08 2004]: Show quoted text
> I'd also like to add that "<" and ">" aren't converted into "&lt;" and > "&gt;" in the diff in HTML mode.
Ugh. Apparently RT suffers from a similar bug, because it doesn't convert ampersand. So for clarification that's "[ampersand]lt;" and "[ampersand]gt;". Might want to make sure ampersand is quoted correctly in the diff output too.
Download (untitled) / with headers
text/plain 248b
Ack, damn HTML. As a workaround I suggest that you either use plain text or have the diff file attached to the message. I'm not sure when I'll have the tuits to work on activitymail again, given that I'm using Subversion more and more these days...
From: moritz[AT]barsnick[DOT]net
Download (untitled) / with headers
text/plain 808b
I've just updated from 1.04 to 1.21 and like some of the new features. I had been patching 1.04 myself. ;-) [DWHEELER - Thu Jun 17 21:19:42 2004]: Show quoted text
> Ack, damn HTML. As a workaround I suggest that you either use plain > text or have the diff file attached to the message.
Oh, I was wondering. I noticed the documentation said to use either -c or -l (I used neither), and once I added -c, it was calling is_last_dir, () which only works if log_dir() was called previously, which is only the case _with_ -l. Hmm. Well, at least I'm glad I found this forum. I will disable -H for now. I'm still looking for a program with nicely formatted output, which doesn't attach the diffs. (cvsreport is very nice for daily summaries but doesn't include diffs in HTML mails.) Thanks for the tool, regards, Moritz
From: David Wheeler <david [...] kineticode.com>
Subject: Re: [cpan #6632] Diffs aren't formatted in a <pre> tag in HTML mode
Date: Mon, 20 Jun 2005 10:16:08 -0700
To: bug-activitymail [...] rt.cpan.org
RT-Send-Cc:
On Jun 20, 2005, at 09:35 , Guest via RT wrote: Show quoted text
>> Ack, damn HTML. As a workaround I suggest that you either use plain >> text or have the diff file attached to the message.
Please try the attached patch. I haven't tested it, but it should be pretty close, if not dead-on. Be sure that you have HTML::Entities installed. Show quoted text
> Oh, I was wondering. I noticed the documentation said to use either -c > or -l (I used neither), and once I added -c, it was calling > is_last_dir, > () which only works if log_dir() was called previously, which is only > the case _with_ -l. Hmm.
Right. Use -l in the commitinfo file, and the use -c in the loginfo file. They depend on each other, but you can't use them in the same execution of the script. Show quoted text
> Well, at least I'm glad I found this forum. I will disable -H for now. > I'm still looking for a program with nicely formatted output, which > doesn't attach the diffs. (cvsreport is very nice for daily summaries > but doesn't include diffs in HTML mails.)
Let me know if the attached patch fixes the issue, and if so, I'll release 1.22. Best, David
Download escape_html.patch
text/x-diff 2.9k

Message body is not shown because sender requested not to inline it.

From: David Wheeler <david [...] kineticode.com>
Subject: Re: [cpan #6632] Diffs aren't formatted in a <pre> tag in HTML mode
Date: Mon, 20 Jun 2005 10:31:31 -0700
To: bug-activitymail [...] rt.cpan.org
RT-Send-Cc:
Download (untitled) / with headers
text/plain 221b
On Jun 20, 2005, at 10:16 , David Wheeler via RT wrote: Show quoted text
> Let me know if the attached patch fixes the issue, and if so, I'll > release 1.22.
Ignore that last patch. I think that this one is closer to it. Best, David
Download escape_html.patch
text/x-diff 3.5k

Message body is not shown because sender requested not to inline it.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.