Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dancer-Plugin-Database CPAN distribution.

Report information
The Basics
Id: 66204
Status: resolved
Priority: 0/
Queue: Dancer-Plugin-Database

People
Owner: Nobody in particular
Requestors: JAWNSY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Missing Dependency on JSON
Download (untitled) / with headers
text/plain 802b
Hello, Thanks for your contribution to the CPAN. While updating the Debian package for this module, I discovered an issue where your module did not specify JSON as a build dependency. It is recommended, but not required, by Dancer, and as such, the to_json command may not work (unless the user has installed JSON). The test that blows up, from t/lib/TestApp.pm appears to be here: get '/quick_select/:id' => sub { my $row = database->quick_select('users', { id => params->{id} }); return to_json($row || { error => 'No matching user' }); }; These issues are resolved by establishing a build-time requirement on the JSON module. I am not sure whether it is also required as a full dependency (I will leave you to decide this, as you are the upstream maintainer). Cheers, Jonathan
Download (untitled) / with headers
text/plain 832b
On 2011-02-26 12:40:33, JAWNSY wrote: Show quoted text
> Hello, > > Thanks for your contribution to the CPAN. > > While updating the Debian package for this module, I discovered an issue > where your module did not specify JSON as a build dependency. It is > recommended, but not required, by Dancer, and as such, the to_json > command may not work (unless the user has installed JSON).
Ah yes, that was incredibly short-sighted of me, thanks for bringing it to my attention! I will get this fixed tomorrow. I'm not sure yet whether to declare JSON as a build-time requirement, or simply refactor the test code to serialise the test data in a much simpler way without requiring JSON. The module certainly doesn't require JSON to operate. Thanks again, I'll update this ticket when this issue has been fixed and a new version released to CPAN.
Download (untitled) / with headers
text/plain 247b
Whoops, looks like this one slipped my mind - sorry for the ridiculous wait. I've just pushed Dancer::Plugin::Database 1.22 to CPAN, which no longer uses to_json() in the tests. Thanks for the report, and sorry again that it took so long to fix!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.