Skip Menu |
 

This queue is for tickets about the HTML-HTML5-Parser CPAN distribution.

Report information
The Basics
Id: 65517
Status: resolved
Priority: 0/
Queue: HTML-HTML5-Parser

People
Owner: perl [...] toby.ink
Requestors: DOUGDUDE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.104



Subject: Please don't require Module::Signature
Download (untitled) / with headers
text/plain 221b
Your Makefile.PL lists Module::Signature as a required module for running your tests. Please, please don't make the end-users install Module::Signature for no reason, as most probably don't have it and/or gunpg installed.
Download (untitled) / with headers
text/plain 644b
On 2011-02-07T07:25:30Z, DOUGDUDE wrote: Show quoted text
> Your Makefile.PL lists Module::Signature as a required module for > running your tests. Please, please don't make the end-users install > Module::Signature for no reason, as most probably don't have it and/or > gunpg installed.
It is not "for no reason". Module::Signature is not really necessary for testing, but version 0.66 is. That is, while it doesn't really matter whether Module::Signature is installed, any version earlier than 0.66 will cause the tests to fail. This could possibly be improved by changing the "requires" to a "recommends" and adding a version check / skip to t/00sig.t.
Subject: Re: [rt.cpan.org #65517] Please don't require Module::Signature
Date: Fri, 11 Feb 2011 03:41:46 -0500
To: <bug-HTML-HTML5-Parser [...] rt.cpan.org>
From: "Douglas Wilson" <doug [...] somethingdoug.com>
Download (untitled) / with headers
text/plain 1.5k
Would it be possible to just remove Module::Signature from Makefile.PL and put in t/00sig.t something like use lib 'inc'; -use Test::More tests => 1; +use Test::More; use Test::Signature; -signature_ok(); +if (eval 'use Module::Signature 0.66; 1') { + plan tests => 1; + signature_ok(); +} else { + plan skip_all =>'Need Module::Signature >= 0.66'; +} This change works well for me; without it, on Windows unless I skip running tests in the CPAN client, this module will not install because 00sig.t fails after Module::Signature never installs. If you check out the CPAN Testers results, Leo Susanto's Win32 results always fail on 00sig.t; I had to alter mine to make them pass. Show quoted text
-----Original Message----- From: Toby Inkster via RT Sent: Friday, February 11, 2011 3:26 To: DOUGDUDE@cpan.org Subject: [rt.cpan.org #65517] Please don't require Module::Signature <URL: https://rt.cpan.org/Ticket/Display.html?id=65517 > On 2011-02-07T07:25:30Z, DOUGDUDE wrote:
> Your Makefile.PL lists Module::Signature as a required module for > running your tests. Please, please don't make the end-users install > Module::Signature for no reason, as most probably don't have it and/or > gunpg installed.
It is not "for no reason". Module::Signature is not really necessary for testing, but version 0.66 is. That is, while it doesn't really matter whether Module::Signature is installed, any version earlier than 0.66 will cause the tests to fail. This could possibly be improved by changing the "requires" to a "recommends" and adding a version check / skip to t/00sig.t.
Fix in 0.104.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.