Skip Menu |
 

This queue is for tickets about the CDDB CPAN distribution.

Report information
The Basics
Id: 65060
Status: resolved
Priority: 0/
Queue: CDDB

People
Owner: Nobody in particular
Requestors: timo.santi [...] digiphilos.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Crashing on line 402 when trying to push undef to @cddbp_hosts
Date: Mon, 24 Jan 2011 13:05:14 +0100
To: "bug-CDDB [...] rt.cpan.org" <bug-CDDB [...] rt.cpan.org>
From: "Santi, Timo" <timo.santi [...] digiphilos.com>
Download (untitled) / with headers
text/plain 875b
Hi, I would like to report a bug regarding cddb.pm v.1.220. cddb.pm crashes on 402 when trying to push undef to @cddbp_hosts. I noticed this bug when I tested my program against network failures. Steps to reproduce the bug. 1. Make a succesful search. cddb.pm adds undef element to @cddbp_hosts-array. 2. Disconnect your network. 3. Make a new search. HOST: while -loop goes through the @cddbp_hosts-array and crashes with the last element which was undef. I don't know the exact reason why the cddb.pm is manipulating the @cddbp_hosts-array. In case of network failure it clears the @cddbp_hosts-array and when the network is again up, there are now server entries in @cddbp_hosts-array. This way cddb.pm doesn't find any results until the called program is restarted. I made a temporarily fix, by moving @cddbp_hosts-array initialization to new(). Best regards, -Timo-
Download (untitled) / with headers
text/plain 579b
Thank you for using the rt.cpan.org bug tracker, without which I may have forgotten your report. commit c5467dc4260c3ceb57e8253957c1449d3d00617a Author: Rocco Caputo <rcaputo@cpan.org> Date: Sun Aug 4 02:01:30 2013 -0400 [rt.cpan.org 65060] Don't destroy the server list when connections fail. Connections may fail for transient reasons. It's better to assume the servers will come back eventually and take the performance hit on reconnect than to exhaust the list and never succeed again. If this fix helps you, thank Timo Santi for reporting the bug.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.