Skip Menu |
 

This queue is for tickets about the Finance-Quote CPAN distribution.

Report information
The Basics
Id: 64419
Status: patched
Worked: 15 min
Priority: 0/
Queue: Finance-Quote

People
Owner: eco [...] ecocode.net
Requestors: feffe [...] mdfnet.se
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Quote-lookup through morningstar.se is broken
Date: Mon, 03 Jan 2011 18:17:33 +0100
To: <bug-Finance-Quote [...] rt.cpan.org>
From: Fredrik Eriksson <feffe [...] mdfnet.se>
Download (untitled) / with headers
text/plain 734b
Hello, Just thought I'd let you know that Morningstar is not working anymore. Since I havn't looked at Finance::Quote or morningstar.se before today, I don't know when it broke. morningstar.se has probably redesigned their homepage since this module was written since the URL in the module ("http://morningstar.se/funds/overview.asp?cid=") gives a 404 error. Even if you change the url to a more correct one ("http://morningstar.se/Funds/Quicktake/Overview.aspx?perfid=") it still fails; probably due to some parsing error. I might have time to look deeper into it and write a fix at some point, but if anyone who knows this stuff can make a quick fix it would be great :) Regards -- Fredrik Eriksson Mälardalens Datorförening
From: Simon Lindgren
Download (untitled) / with headers
text/plain 968b
Vid Mon, 03 Jan 2011 kl. 12.15.57, skrev feffe@mdfnet.se: Show quoted text
> > Hello, > > Just thought I'd let you know that Morningstar is not working anymore. > Since I havn't looked at Finance::Quote or morningstar.se before today, I > don't know when it broke. > > morningstar.se has probably redesigned their homepage since this module > was written since the URL in the module > ("http://morningstar.se/funds/overview.asp?cid=") gives a 404 error. Even > if you change the url to a more correct one > ("http://morningstar.se/Funds/Quicktake/Overview.aspx?perfid=") it still > fails; probably due to some parsing error. I might have time to look
deeper Show quoted text
> into it and write a fix at some point, but if anyone who knows this stuff > can make a quick fix it would be great :) >
I have a branch here with a fix: https://github.com/riviti/finance-quote/branches/Morningstar Wasn't aware of this bug until now, though maybe you've already seen this branch on finance-quote-devel?
Subject: [rt.cpan.org #64419] patch
Date: Sat, 19 Sep 2015 00:01:49 +0200
To: bug-Finance-Quote [...] rt.cpan.org
From: Anton Lindström <anton [...] antonanton.com>
Download (untitled) / with headers
text/plain 192b
Hi, I wanted to get this working so I've created a patch for morningstar.se. I also had to patch the test file since it looked for a fund that doesn't exist any more. best regards -- Anton
Download morningstar.t.patch
text/x-diff 1.4k

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 315b
On Fri Sep 18 18:04:34 2015, anton@antonanton.com wrote: Show quoted text
> Hi, > > I wanted to get this working so I've created a patch for morningstar.se. > I also had to patch the test file since it looked for a fund that > doesn't exist any more. > > best regards
Thanks! patch applied and appended to master branch -- Erik


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.