Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 64353
Status: resolved
Priority: 0/
Queue: Test-Harness

People
Owner: andy [...] hexten.net
Requestors: cberry [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.22
Fixed in: 3.29



Subject: [PATCH] VMS nits in source.t
This test has been failing on VMS since 3.22 came into core (yeah, awhile ago). The attached patch makes two small changes that clear the smoke: 1.) If the directory name passed to assemble_meta() is in native format (which is what's returned from F::S::catdir), we were getting an empty basename in the returned metadata because there is no basename on a directory. '[.t.source_tests]' is logically equivalent to 't/source_tests/' (with the trailing slash), but on VMS the trailing delimiter is non-optional. In other words, basenames on directories stand on shaky ground; without the trailing delimiter you get the bare directory name, but with the trailing delimiter (which is required on VMS) you get nothing. The patch dodges the issue by explicitly specifying the directory in Unix format. 2.) Symlinks exist on recent versions of VMS, but in various ways are not ready for primetime. For example, a link can't point to an absolute path without a special environment's being set up. So I think the better part of valor is to skip those tests for now. Patch is against core so apply with -p2.
Subject: source_t.patch
Download source_t.patch
text/x-diff 662b
--- cpan/Test-Harness/t/source.t;-0 2010-08-16 11:07:13 -0500 +++ cpan/Test-Harness/t/source.t 2010-12-30 08:24:22 -0600 @@ -9,10 +9,7 @@ use strict; use Test::More tests => 45; use File::Spec; -my $dir = File::Spec->catdir( - 't', - 'source_tests' -); +my $dir = 't/source_tests'; use_ok('TAP::Parser::Source'); @@ -236,6 +233,7 @@ sub ct($) { # symlink test SKIP: { my $symlink_exists = eval { symlink( '', '' ); 1 }; + $symlink_exists = 0 if $^O eq 'VMS'; # exists but not ready for prime time skip 'symlink not supported on this platform', 9 unless $symlink_exists; my $test = File::Spec->catfile( $dir, 'source.t' );
Download (untitled) / with headers
text/plain 378b
Please could you consider rolling a new CPAN release with the patch from https://rt.cpan.org/Ticket/Display.html?id=64353 included? This is the only divergence between the current CPAN release and bleadperl, and it would be great to get the two back in sync. It isn't urgent, but if you were able to do this before the next Perl release on 20th August I would be very grteful.
Download (untitled) / with headers
text/plain 1.2k
On Thu Dec 30 20:44:27 2010, CBERRY wrote: Show quoted text
> This test has been failing on VMS since 3.22 came into core (yeah, > awhile ago). The attached > patch makes two small changes that clear the smoke: > > 1.) If the directory name passed to assemble_meta() is in native > format (which is what's > returned from F::S::catdir), we were getting an empty basename in the > returned metadata > because there is no basename on a directory. '[.t.source_tests]' is > logically equivalent to > 't/source_tests/' (with the trailing slash), but on VMS the trailing > delimiter is non-optional. In > other words, basenames on directories stand on shaky ground; without > the trailing delimiter > you get the bare directory name, but with the trailing delimiter > (which is required on VMS) > you get nothing. The patch dodges the issue by explicitly specifying > the directory in Unix > format. > > 2.) Symlinks exist on recent versions of VMS, but in various ways are > not ready for > primetime. For example, a link can't point to an absolute path > without a special > environment's being set up. So I think the better part of valor is to > skip those tests for now. > > Patch is against core so apply with -p2.
I just pushed the patch, it will be part of the upcoming 3.29 release. Leon


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.