Skip Menu |
 

This queue is for tickets about the HTML-Widget CPAN distribution.

Report information
The Basics
Id: 63583
Status: open
Priority: 0/
Queue: HTML-Widget

People
Owner: Nobody in particular
Requestors: CARNIL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Failing tests when using HTML::Tree (>= 4.0)
Date: Sat, 4 Dec 2010 09:10:01 +0100
To: bug-HTML-Widget [...] rt.cpan.org
From: Salvatore Bonaccorso <carnil [...] cpan.org>
Download (untitled) / with headers
text/plain 502b
Hi Carl When building HTML::Widget with using HTML::Tree (>= 4.0) some tests fails (see [1]). [1] http://bugs.debian.org/605809 Indeed the Changes for HTML::Tree contains: 4.0 Mon Sep 20 2010 [THINGS THAT MAY BREAK YOUR CODE OR TESTS] * Changes to entity encoding from ord values to XML entities may break tests expecting &#00; style encoding. * Attribute names are now validated in as_XML and invalid names will cause an error. Thanks for considering, Bests Salvatore
Download signature.asc
application/pgp-signature 835b

Message body not shown because it is not plain text.

I don't know if anyone is using this or not, but hit this when doing some overlay cleaning on gentoo.

 

Attached is a patch for this specific problem, but the hash-randomness in 5.18 is still present.

Subject: rt63583.patch
Download rt63583.patch
text/x-diff 1.4k
diff -Naur t/04basic.t t/04basic.t --- t/04basic.t 2007-03-01 15:42:26.000000000 +0000 +++ t/04basic.t 2014-09-01 16:31:49.592374273 +0000 @@ -82,7 +82,7 @@ is( $c->error_xml, <<EOF, 'Error XML output is ok' ); <span class="error_messages" id="widget_age_errors"><span class="regex_errors" id="widget_age_error_regex">Contains digit characters.</span></span> EOF - is( $c->javascript_xml, <<EOF, 'JavScript XML output is ok' ); + is( $c->javascript_xml, ( substr <<EOF, 0, -1 ), 'JavScript XML output is ok' ); <script type="text/javascript"> <!-- diff -Naur t/06bugs_xml_escape.t t/06bugs_xml_escape.t --- t/06bugs_xml_escape.t 2007-03-01 16:05:40.000000000 +0000 +++ t/06bugs_xml_escape.t 2014-09-01 16:32:15.889098013 +0000 @@ -23,5 +23,5 @@ like( "$f", qr'value="é"', 'utf-8 character ok' ); - like( "$f", qr'value="&#34; foo &#62;"', '' ); + like( "$f", qr'value="&quot; foo &gt;"', '' ); } diff -Naur t/07custom_render.t t/07custom_render.t --- t/07custom_render.t 2007-03-01 15:42:26.000000000 +0000 +++ t/07custom_render.t 2014-09-01 16:32:45.904641305 +0000 @@ -119,7 +119,7 @@ is( $c->error_xml, <<EOF, 'Error XML output is ok' ); <span class="error_messages" id="widget_age_errors"><span class="regex_errors" id="widget_age_error_regex">Contains digit characters.</span></span> EOF - is( $c->javascript_xml, <<EOF, 'JavScript XML output is ok' ); + is( $c->javascript_xml, ( substr <<EOF, 0, -1 ), 'JavScript XML output is ok' ); <script type="text/javascript"> <!--


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.