Skip Menu |
 

This queue is for tickets about the Net-IMAP-Simple CPAN distribution.

Report information
The Basics
Id: 63282
Status: resolved
Priority: 0/
Queue: Net-IMAP-Simple

People
Owner: jettero [...] cpan.org
Requestors: nfhm2k [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Flags missing from msg_flags
Date: Tue, 23 Nov 2010 16:13:09 +0000
To: bug-Net-IMAP-Simple [...] rt.cpan.org
From: HM 2K <nfhm2k [...] gmail.com>
Download (untitled) / with headers
text/plain 430b
Available server flags: $MDNSent, Junk, NonJunk, \Draft, \Answered, \Flagged, \Deleted, \Seen, \Recent However, msg_flags never seems to return the Junk or NonJunk flags. Is this possibly a parse issue? I've had a look at the msg_flags subroutine but haven't tested the regex yet. On the description for the put subroutine I see it says "they must start with a slash", yet I can't seem to locate where it says this in the RFC.
Download (untitled) / with headers
text/plain 780b
This handling is clearly very wrong. The two relevant subs are linked below. Clearly it's not ever going to get the flags right with this RE: m/^\\\w+\z/ I can't see what else is going to break if we fix this, but I suspect it's enough to simply split on space as the RFC seems to suggest we should. I also wonder if we should try to get server/folder supported flags from the SELECT statement (as the RFC further intends). I'm open to whatever ideas you have. This wants to get fixed. https://github.com/jettero/net--imap--simple/blob/master/Simple.pm#L661 https://github.com/jettero/net--imap--simple/blob/master/Simple.pm#L620 -- If riding in an airplane is flying, then riding in a boat is swimming. 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles.
Subject: Re: [rt.cpan.org #63282] Flags missing from msg_flags
Date: Tue, 23 Nov 2010 17:23:23 +0000
To: bug-Net-IMAP-Simple [...] rt.cpan.org
From: HM 2K <nfhm2k [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
I agree. I don't see why the regex needs to be so restrictive. It only needs to work very similar to the flags subroutine, split by the space. I think it would be wise to follow the RFC as closely as possible, although I don't see the need to check what flags are supported when reading, perhaps only when writing, which is beyond the scope of this bug really. I see no reason not to just split by space. I look forward to a fix. On Tue, Nov 23, 2010 at 4:30 PM, Paul Miller via RT < bug-Net-IMAP-Simple@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=63282 > > > This handling is clearly very wrong. The two relevant subs are linked > below. > > Clearly it's not ever going to get the flags right with this RE: > > m/^\\\w+\z/ > > I can't see what else is going to break if we fix this, but I suspect > it's enough to simply split on space as the RFC seems to suggest we > should. I also wonder if we should try to get server/folder supported > flags from the SELECT statement (as the RFC further intends). > > I'm open to whatever ideas you have. This wants to get fixed. > > > https://github.com/jettero/net--imap--simple/blob/master/Simple.pm#L661 > > > https://github.com/jettero/net--imap--simple/blob/master/Simple.pm#L620 > > > > -- > If riding in an airplane is flying, then riding in a boat is swimming. > 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles. > >
Download (untitled) / with headers
text/plain 452b
Wrote a test for this. I'm still not totally sure how I want to resolve it, but it seems I'm just going to remove the grep. I think it's enough to accept the space separated list. The base module doesn't have a proper parser, or I could be a little more precise (see SimpleX). Prolly post a fix in a couple hours. -- If riding in an airplane is flying, then riding in a boat is swimming. 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles.
Download (untitled) / with headers
text/plain 330b
I just pushed 1.2019 to github. I'm pretty sure it will solve this for you (per tests), but it'd be cool if you could try ot also. https://github.com/jettero/net--imap--simple/archives/1.2019 -- If riding in an airplane is flying, then riding in a boat is swimming. 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles.
Subject: Re: [rt.cpan.org #63282] Flags missing from msg_flags
Date: Thu, 28 Apr 2011 10:31:03 +0100
To: bug-Net-IMAP-Simple [...] rt.cpan.org
From: HM 2K <nfhm2k [...] gmail.com>
Download (untitled) / with headers
text/plain 608b
Further to this, can you advise how one would correctly use or install this from the tarball? Thanks. On Thu, Dec 2, 2010 at 2:38 AM, Paul Miller via RT < bug-Net-IMAP-Simple@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=63282 > > > I just pushed 1.2019 to github. I'm pretty sure it will solve this for > you (per tests), but it'd be cool if you could try ot also. > > https://github.com/jettero/net--imap--simple/archives/1.2019 > > > > -- > If riding in an airplane is flying, then riding in a boat is swimming. > 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles. > >
Subject: Re: [rt.cpan.org #63282] Flags missing from msg_flags
Date: Thu, 28 Apr 2011 11:04:14 +0100
To: bug-Net-IMAP-Simple [...] rt.cpan.org
From: HM 2K <nfhm2k [...] gmail.com>
Download (untitled) / with headers
text/plain 2.1k
Scrap that it installed OK: [root@blade jettero-net--imap--simple-6f5a651]# perl Makefile.PL Do you wish to include some simple protocol extensions (pulls in Parse::RecDescent)? [y] y Checking if your kit is complete... Looks good Writing Makefile for Net::IMAP::Simple [root@blade jettero-net--imap--simple-6f5a651]# make cp Simple.pm blib/lib/Net/IMAP/Simple.pm cp SimpleX.pm blib/lib/Net/IMAP/SimpleX.pm cp SimpleX.pod blib/lib/Net/IMAP/SimpleX.pod cp Simple.pod blib/lib/Net/IMAP/Simple.pod cp lib/Net/IMAP/Simple/PipeSocket.pm blib/lib/Net/IMAP/Simple/PipeSocket.pm Manifying blib/man3/Net::IMAP::SimpleX.3pm Manifying blib/man3/Net::IMAP::Simple.3pm Manifying blib/man3/Net::IMAP::Simple::PipeSocket.3pm [root@blade jettero-net--imap--simple-6f5a651]# make install Installing /usr/lib/perl5/site_perl/5.8.8/Net/IMAP/SimpleX.pm Installing /usr/lib/perl5/site_perl/5.8.8/Net/IMAP/SimpleX.pod Installing /usr/lib/perl5/site_perl/5.8.8/Net/IMAP/Simple.pm Installing /usr/lib/perl5/site_perl/5.8.8/Net/IMAP/Simple.pod Installing /usr/lib/perl5/site_perl/5.8.8/Net/IMAP/Simple/PipeSocket.pm Installing /usr/share/man/man3/Net::IMAP::Simple.3pm Installing /usr/share/man/man3/Net::IMAP::SimpleX.3pm Installing /usr/share/man/man3/Net::IMAP::Simple::PipeSocket.3pm Writing /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Net/IMAP/Simple/.packlist Appending installation info to /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod It tested fine. You should close this issue and push to cpan for release. On Thu, Apr 28, 2011 at 10:31 AM, HM 2K <nfhm2k@gmail.com> wrote: Show quoted text
> Further to this, can you advise how one would correctly use or install this > from the tarball? > > Thanks. > > > On Thu, Dec 2, 2010 at 2:38 AM, Paul Miller via RT < > bug-Net-IMAP-Simple@rt.cpan.org> wrote: >
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=63282 > >> >> I just pushed 1.2019 to github. I'm pretty sure it will solve this for >> you (per tests), but it'd be cool if you could try ot also. >> >> https://github.com/jettero/net--imap--simple/archives/1.2019 >> >> >> >> -- >> If riding in an airplane is flying, then riding in a boat is swimming. >> 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles. >> >>
>
Download (untitled) / with headers
text/plain 270b
Seems like I'm way past it. The current CPAN version is 1.2022. I don't really recall the ordering since this was quite a while ago. -- If riding in an airplane is flying, then riding in a boat is swimming. 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.