Skip Menu |
 

This queue is for tickets about the PathTools CPAN distribution.

Report information
The Basics
Id: 63117
Status: open
Priority: 0/
Queue: PathTools

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
njh [...] bandsman.co.uk
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.33
Fixed in: (no value)



Subject: Use of uninitialized value $_[0] in join or string at /usr/local/lib/perl/5.10.1/File/Spec/Unix.pm
Download (untitled) / with headers
text/plain 371b
catdir doesn't check its arguments. This patch should correct this: *** OUnix.pm 2010-11-18 14:23:52.000000000 +0000 --- Unix.pm 2010-11-18 14:24:55.000000000 +0000 *************** *** 83,88 **** --- 83,90 ---- sub catdir { my $self = shift; + return unless @_; # NHORNE + $self->canonpath(join('/', @_, '')); # '' because need a trailing '/' }
From: njh [...] bandsman.co.uk
With hindsight, a better fix would be: return unless $_[0]; # NHORNE
Download (untitled) / with headers
text/plain 312b
On Sat Nov 27 08:37:41 2010, njh@bandsman.co.uk wrote: Show quoted text
> With hindsight, a better fix would be: > > return unless $_[0]; # NHORNE
It appears that File::Spec::Unix::catdir() is now handled in dist/Cwd/Cwd.xs. So I'm not sure that your suggestion is still applicable. Thank you very much. Jim Keenan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.