Skip Menu |
 

This queue is for tickets about the HTTP-Parser-XS CPAN distribution.

Report information
The Basics
Id: 63074
Status: resolved
Priority: 0/
Queue: HTTP-Parser-XS

People
Owner: Nobody in particular
Requestors: james2vegas [...] aim.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.08
  • 0.09
  • 0.10
  • 0.11
  • 0.12
Fixed in: (no value)



Subject: 0.08 breaks on older (2.x) gcc compilers
/usr/libexec/ld-elf.so.1: /usr/local/lib/perl5/site_perl/5.8.9/i386-freebsd/auto/HTTP/Parser/XS/XS.so: Undefined symbol "__builtin_expect"
Changing the check in picohttpparser/picohttpparser.c to be explicit about GCC version fixes it:

--- picohttpparser/picohttpparser.c.orig        Tue Nov 16 21:28:14 2010
+++ picohttpparser/picohttpparser.c     Tue Nov 16 21:28:41 2010
@@ -1,7 +1,7 @@
 #include <stddef.h>
 #include "picohttpparser.h"
 
-#ifdef __GNUC__
+#if __GNUC__ >= 3
 # define likely(x)     __builtin_expect(!!(x), 1)
 # define unlikely(x)   __builtin_expect(!!(x), 0)
 #else

Thank you for reporting. Fixed in 0.13.
Thank you for reporting. Fixed in 0.13.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.