Skip Menu |
 

This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id: 62847
Status: resolved
Priority: 0/
Queue: Module-Install

People
Owner: Nobody in particular
Requestors: gfuji [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.10



Subject: [PATCH] Module::Install is incredibly slow
Download (untitled) / with headers
text/plain 380b
Hi, I thought Makefile.PL on Module::Install is really slow so that I couldn't continue to use it, but by profiling I found that the bottleneck: Cwd::cwd(), which does `pwd`, instead of getcwd(3), and that Use of Cwd::getcwd() makes M::I significantly faster! Please review my patch, which includes some other performance tuning. Regards, -- Goro Fuji (gfx) GFUJI at CPAN.org
Subject: bottleneck.patch
Download bottleneck.patch
text/x-diff 2.6k
diff --git a/lib/Module/AutoInstall.pm b/lib/Module/AutoInstall.pm index bd50f58..e13e70e 100644 --- a/lib/Module/AutoInstall.pm +++ b/lib/Module/AutoInstall.pm @@ -101,7 +101,7 @@ sub import { print "*** $class version " . $class->VERSION . "\n"; print "*** Checking for Perl dependencies...\n"; - my $cwd = Cwd::cwd(); + my $cwd = Cwd::getcwd(); $Config = []; diff --git a/lib/Module/Install.pm b/lib/Module/Install.pm index 489b0a7..528f4b0 100644 --- a/lib/Module/Install.pm +++ b/lib/Module/Install.pm @@ -155,10 +155,10 @@ END_DIE sub autoload { my $self = shift; my $who = $self->_caller; - my $cwd = Cwd::cwd(); + my $cwd = Cwd::getcwd(); my $sym = "${who}::AUTOLOAD"; $sym->{$cwd} = sub { - my $pwd = Cwd::cwd(); + my $pwd = Cwd::getcwd(); if ( my $code = $sym->{$pwd} ) { # Delegate back to parent dirs goto &$code unless $cwd eq $pwd; @@ -238,7 +238,7 @@ sub new { # ignore the prefix on extension modules built from top level. my $base_path = Cwd::abs_path($FindBin::Bin); - unless ( Cwd::abs_path(Cwd::cwd()) eq $base_path ) { + unless ( Cwd::abs_path(Cwd::getcwd()) eq $base_path ) { delete $args{prefix}; } return $args{_self} if $args{_self}; @@ -337,7 +337,7 @@ sub find_extensions { if ( $subpath eq lc($subpath) || $subpath eq uc($subpath) ) { my $content = Module::Install::_read($subpath . '.pm'); my $in_pod = 0; - foreach ( split //, $content ) { + foreach ( split /\n/, $content ) { $in_pod = 1 if /^=\w/; $in_pod = 0 if /^=cut/; next if ($in_pod || /^=cut/); # skip pod text diff --git a/lib/Module/Install/Admin/Bundle.pm b/lib/Module/Install/Admin/Bundle.pm index 7641986..c371992 100644 --- a/lib/Module/Install/Admin/Bundle.pm +++ b/lib/Module/Install/Admin/Bundle.pm @@ -2,8 +2,6 @@ package Module::Install::Admin::Bundle; use strict; use Module::Install::Base; -use Module::CoreList; -use LWP::UserAgent; use vars qw{$VERSION @ISA}; BEGIN { diff --git a/lib/Module/Install/Admin/Manifest.pm b/lib/Module/Install/Admin/Manifest.pm index bcf088e..9f1f4e2 100644 --- a/lib/Module/Install/Admin/Manifest.pm +++ b/lib/Module/Install/Admin/Manifest.pm @@ -9,7 +9,7 @@ BEGIN { @ISA = qw{Module::Install::Base}; } -use Cwd; +use Cwd (); use File::Spec; # XXX I really want this method in Module::Install::Admin::Makefile @@ -93,7 +93,7 @@ sub _read_manifest { my $manifest_path = ''; my $relative_path = ''; my @relative_dirs = (); - my $cwd = Cwd::cwd(); + my $cwd = Cwd::getcwd(); my @cwd_dirs = File::Spec->splitdir($cwd); while ( @cwd_dirs ) { last unless -f File::Spec->catfile(@cwd_dirs, 'Makefile.PL');
Download (untitled) / with headers
text/plain 197b
On Sun Mar 23 17:31:45 2014, bowtie wrote: Show quoted text
Huzzah! Thank you! Closing with thanks for being awesome. :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.